Skip to content

Always erase last known value from instances when using binder or partial types - #7354

Merged
ilevkivskyi merged 3 commits into
python:masterfrom
ilevkivskyi:binder-literal
Aug 16, 2019
Merged

ilevkivskyi merged 3 commits into
python:masterfrom
ilevkivskyi:binder-literal

Conversation

@ilevkivskyi

@ilevkivskyi ilevkivskyi commented Aug 16, 2019 •

Copy link
Copy Markdown
Member

See the test cases for simplified example of currently problematic behaviour when using --strict-equality.

@Michael0x2a Michael0x2a left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ilevkivskyi ilevkivskyi changed the title Always erase last known value from instances when using binder Always erase last known value from instances when using binder or partial types Aug 16, 2019
@ilevkivskyi

Copy link
Copy Markdown
Member Author

Hm, this is one more case when binder and partial types share bugs. Looks like another argument in favour of trying to combine them.

@ilevkivskyi
ilevkivskyi merged commit 858a243 into python:master Aug 16, 2019
@ilevkivskyi
ilevkivskyi deleted the binder-literal branch August 16, 2019 18:27
JukkaL added a commit that referenced this pull request Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants