Skip to content

Typeshed cherry-pick: Replace some literal types in logging (#7354) - #12239

Merged
JukkaL merged 1 commit into
masterfrom
typeshed-cp2
Feb 22, 2022
Merged

JukkaL merged 1 commit into
masterfrom
typeshed-cp2

Conversation

@JukkaL

@JukkaL JukkaL commented Feb 22, 2022

Copy link
Copy Markdown
Collaborator

Fixes some regressions.

Context: python/typeshed#7258

@github-actions

Copy link
Copy Markdown
Contributor

Diff from mypy_primer, showing the effect of this PR on open source code:

pip (https://github.com/pypa/pip)
- src/pip/_internal/locations/__init__.py:68: error: Incompatible types in assignment (expression has type "Literal[10]", variable has type "Literal[30]")
- src/pip/_internal/utils/logging.py:231: error: Incompatible types in assignment (expression has type "int", variable has type "Literal[10]")
- src/pip/_internal/utils/logging.py:233: error: Incompatible types in assignment (expression has type "Literal[30]", variable has type "Literal[10]")
- src/pip/_internal/utils/logging.py:235: error: Incompatible types in assignment (expression has type "Literal[40]", variable has type "Literal[10]")
- src/pip/_internal/utils/logging.py:237: error: Incompatible types in assignment (expression has type "Literal[50]", variable has type "Literal[10]")
- src/pip/_internal/utils/logging.py:239: error: Incompatible types in assignment (expression has type "Literal[20]", variable has type "Literal[10]")
- src/pip/_internal/utils/subprocess.py:125: error: Incompatible types in assignment (expression has type "int", variable has type "Literal[20]")

streamlit (https://github.com/streamlit/streamlit)
- lib/streamlit/logger.py: note: In function "set_log_level":
- lib/streamlit/logger.py:41:21: error: Incompatible types in assignment (expression has type "Literal[40]", variable has type "Literal[50]")  [assignment]
- lib/streamlit/logger.py:43:21: error: Incompatible types in assignment (expression has type "Literal[30]", variable has type "Literal[50]")  [assignment]
- lib/streamlit/logger.py:45:21: error: Incompatible types in assignment (expression has type "Literal[20]", variable has type "Literal[50]")  [assignment]
- lib/streamlit/logger.py:47:21: error: Incompatible types in assignment (expression has type "Literal[10]", variable has type "Literal[50]")  [assignment]
- lib/streamlit/logger.py:57:17: error: Incompatible types in assignment (expression has type "Literal[50]", variable has type "Literal[20]")  [assignment]

@JukkaL
JukkaL merged commit bb1fda3 into master Feb 22, 2022
@JukkaL
JukkaL deleted the typeshed-cp2 branch February 22, 2022 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants