Skip to content

Updated dead or redirected links - #373

Merged
willingc merged 8 commits into
python:masterfrom
vaibssingh:master
May 19, 2018
Merged

willingc merged 8 commits into
python:masterfrom
vaibssingh:master

Conversation

@vaibssingh

@vaibssingh vaibssingh commented May 16, 2018 •

Copy link
Copy Markdown
Contributor

Made changes to old links in communication.rst, compiler.rst and coverity.rst. Referred in #371

Updated links and redirections.
Updated the Drive link on line 581
@the-knights-who-say-ni

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

When your account is ready, please add a comment in this pull request
and a Python core developer will remove the CLA not signed label
to make the bot check again.

Thanks again to your contribution and we look forward to looking at it!

@vaibssingh vaibssingh changed the title Updated links as per #371 Updated dead and redirected links May 16, 2018
@vaibssingh

vaibssingh commented May 16, 2018 •

Copy link
Copy Markdown
Contributor Author

To anybody reading this, the CLA has been signed as mentioned by @the-knights-who-say-ni

@vaibssingh vaibssingh changed the title Updated dead and redirected links Updated dead or redirected links May 16, 2018
Comment thread communication.rst Outdated
-----

We have our own `zulipchat <https://python.zulipchat.com>`_ instance. This should be
We have our own `zulipchat <https://python.zulipchat.com/login/>`_ instance. This should be

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only redirects to /login/ if you are not already logged in. Can we keep the original?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep the original as suggested by @encukou.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@willingc Okay!

Comment thread coverity.rst Outdated
.. _Coverity Scan: http://scan.coverity.com/
.. _Coverity Scan: https://scan.coverity.com/

.. _Coverity Connect: http://scan5.coverity.com:8080/

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@encukou Gotcha! :)

Made changes as suggessted on the previous PR python#371
Updated drive link on line 581
Updated link to coverity connect on line 151
@vaibssingh

Copy link
Copy Markdown
Contributor Author

@encukou Have made the recommended changes. Please review 😀

Comment thread communication.rst Outdated

A complete list of Python mailing lists can be found at https://mail.python.org.
Most lists are also mirrored at http://news.gmane.org/ and can be read and
Most lists are also mirrored at [GMANE](http://gmane.org) and can be read and

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @vaibssingh. I gave you the markdown link format instead of reStructuredText. This link will need to be changed to use rst. Thanks.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@willingc I am sorry but I don't understand 😅 Can you please provide an example?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Markdown markup, a link is specified like this: [GMANE](http://gmane.org)

In reStructuredText markup, a link is specified like this:

`GMANE <http://gmane.org>`_

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your clear explanation! Shall keep in mind for next time.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

Changed GMANE link to rst link on line 60

@willingc willingc left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thanks @vaibssingh.

@willingc
willingc merged commit 61ae39e into python:master May 19, 2018
@willingc

Copy link
Copy Markdown
Collaborator

Thanks for the contribution @vaibssingh. 🍰

AA-Turner pushed a commit to AA-Turner/devguide that referenced this pull request Jun 17, 2022
* Update communication.rst

Updated links and redirections.

* Update compiler.rst

Updated the Drive link on line 581

* Update coverity.rst

* Update communication.rst

Made changes as suggessted on the previous PR python#371

* Update compiler.rst

Updated drive link on line 581

* Update coverity.rst

Updated link to coverity connect on line 151

* Update communication.rst

Changed GMANE link to rst link on line 60
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants