You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Clean up out of date or permanently redirected links #371
Several files need some clean up on their links. For those sprinting at PyCon, feel free to choose a file, make updates, and file a PR with the changes. Please leave a message below indicating the file which you are currently working on. Thanks.
@willingc Hi! I would like to work on this. Before I start, just for clarification, for the links that are broken, we have to remove them, the permanent redirects are to be updated and for those links which were 'Found' after redirection are to be left as it is, right? Or they need to be updated with the direct links as well?
Thanks @vaibssingh. Great! Why don't you claim 3 of the files (just leave a message here saying which ones) and let others contribute the rest of the files since this is a good issue for newcomers 😄
For clarification:
I would not remove links without pinging me here first since we may wish to find a better source for those.
For permanent redirects, go ahead and update the link to the new location
For links that are 'Found' after redirection, I would leave the original links [@encukou provides a good explanation below]
I will be happy to update these two links as well if you can provide their working alternates to me. Meanwhile I am opening a PR for the rest of the updates.
I don't think following 302 Found redirects is the way to go – some of these are short URLs, and the target URL looks more like an implementation detail. For example:
@willingc One more thing, in coverity.rst, most of the redirections are happening because of previous links being http while the updated links are https. So I haven't reverted that update. Do I need to change them back to http as well because it makes more sense having https links directly?
I skimmed through the output from .\make linkcheck & observed these:
developers.rst has no errors besides a redirect to https://github.com/orgs/python/teams/python-core which I believe can only be accessed by the members.
docquality.rst has a link to the email - docs@python.org which has moved to https://mail.python.org/mailman3/lists/docs.python.org/.
exploring.rst has two articles - "Python Asynchronous I/O Walkthrough" & "CPython internals: A ten-hour codewalk through the Python interpreter source code", the author of which is the same. Although the former seems to have been removed the latter is still accessible. The second article also has a warning "to not link to it any more as they can be removed any time".
index.rst has a couple of redirects to new addresses except the "Meta Tracker" under Key Resources is broken. Should I remove it then?
motivations.rst has a few more redirects to new addresses. The link to the GSoC although returns a 200 status code, the page appears to be outdated & even has a message suggesting the same. The new site seems to have moved over here - https://python-gsoc.org/, should I update it?
setup.rst needs to be updated addresses for GitHub docs, ccache to https://ccache.dev/ & the homepage for Visual Studio.
triaging.rst again couple of redirects but the link to "Python organization admin" under Becoming a member of the Python triage team directs to https://devguide.python.org/devcycle/?highlight=organization admin#current-owners which can perhaps be improved to something like - https://devguide.python.org/devcycle/#organization-owner-policy or https://devguide.python.org/devcycle/#current-owners. Or is it better left as it is right now?
These were the files @willingc specifically pointed out for fixing. But since the moment this issue thread was created, a couple of other files contain broken links as well. Do they need to be cleaned too?
I skimmed through briefly & found these documents requiring attention as well:
I can take a look into these issues over the weekends & replace the older links to the newer redirected ones as per the following suggestions.
Thanks @vaibssingh. Great! Why don't you claim 3 of the files (just leave a message here saying which ones) and let others contribute the rest of the files since this is a good issue for newcomers 😄
For clarification:
I would not remove links without pinging me here first since we may wish to find a better source for those.
For permanent redirects, go ahead and update the link to the new location
For links that are 'Found' after redirection, I would leave the original links [@encukou provides a good explanation below]
Activity
vaibssingh commentedon May 16, 2018
@willingc Hi! I would like to work on this. Before I start, just for clarification, for the links that are broken, we have to remove them, the permanent redirects are to be updated and for those links which were 'Found' after redirection are to be left as it is, right? Or they need to be updated with the direct links as well?
willingc commentedon May 16, 2018
Thanks @vaibssingh. Great! Why don't you claim 3 of the files (just leave a message here saying which ones) and let others contribute the rest of the files since this is a good issue for newcomers 😄
For clarification:
vaibssingh commentedon May 16, 2018
@willingc Gotcha! So I am starting on the top three files (communication.rst, compilation.rst, coverity.rst). Shall send the PR once done.
vaibssingh commentedon May 16, 2018
@willingc So I have made the changes as needed. There are two broken links which need to be replaced.
In communication.rst:
In coverity.rst
I will be happy to update these two links as well if you can provide their working alternates to me. Meanwhile I am opening a PR for the rest of the updates.
vaibssingh commentedon May 16, 2018
@willingc Here is the PR #373
encukou commentedon May 16, 2018
@tiran, http://scan5.coverity.com:8080/ still works if you are logged in, right?
tiran commentedon May 16, 2018
@encukou It's https://scan.coverity.com/projects/python nowadays.
encukou commentedon May 16, 2018
I don't think following
302 Foundredirects is the way to go – some of these are short URLs, and the target URL looks more like an implementation detail. For example:https://youtu.be/-Nk-8fSJM6I→https://www.youtube.com/watch?v=-Nk-8fSJM6I&feature=youtu.behttps://drive.google.com/open?id=...→https://drive.google.com/file/d/.../view?usp=drive_webwillingc commentedon May 16, 2018
@encukou's suggestion to keep the shorter URL is reasonable as these are producing a
make linkcheckwarning and not error.@vaibssingh, would you mind going back and leave the 302 Found warnings with the original URL? Sorry for the confusion.
willingc commentedon May 16, 2018
@vaibssingh For the GMANE link, let's change the sentence to:
vaibssingh commentedon May 17, 2018
@willingc Have made all the changes as needed. Please review if anything else needs to be done. 😀
Update communication.rst
vaibssingh commentedon May 17, 2018
@willingc One more thing, in coverity.rst, most of the redirections are happening because of previous links being http while the updated links are https. So I haven't reverted that update. Do I need to change them back to http as well because it makes more sense having https links directly?
3 remaining items
willingc commentedon Aug 25, 2018
Sure @anubhavsinha98.
anubhavsinha98 commentedon Aug 25, 2018
@willingc
What should I do, should I delete these links or update them with new ones?
anubhavsinha98 commentedon Aug 27, 2018
Please review @willingc ?
Mariatta commentedon Aug 27, 2018
https://github.com/orgs/python/teams/python-core
That link is only available for people within Python organization. We can leave it in.
http://sphinx.pocoo.org/contents.html can be replaced with http://www.sphinx-doc.org/.
anubhavsinha98 commentedon Aug 27, 2018
ok @Mariatta thanks!
anubhavsinha98 commentedon Aug 27, 2018
@willingc and @Mariatta PR sent #410
Please check it out !
farhaanbukhsh commentedon Sep 13, 2018
Hey @willingc I would like to help with this issue, should I pick up 3 files as well?
SubhrajyotiSen commentedon Oct 11, 2019
I would like to pick up
triaging.rstramyaparimi commentedon Jul 28, 2020
Hi,
I would like to contribute to this issue. Is this still open? Can I take one of the files?
Thanks
jarmos-san commentedon Oct 7, 2020
I skimmed through the output from
.\make linkcheck& observed these:developers.rsthas no errors besides a redirect tohttps://github.com/orgs/python/teams/python-corewhich I believe can only be accessed by the members.docquality.rsthas a link to the email - docs@python.org which has moved tohttps://mail.python.org/mailman3/lists/docs.python.org/.exploring.rsthas two articles - "Python Asynchronous I/O Walkthrough" & "CPython internals: A ten-hour codewalk through the Python interpreter source code", the author of which is the same. Although the former seems to have been removed the latter is still accessible. The second article also has a warning "to not link to it any more as they can be removed any time".index.rsthas a couple of redirects to new addresses except the "Meta Tracker" under Key Resources is broken. Should I remove it then?motivations.rsthas a few more redirects to new addresses. The link to the GSoC although returns a 200 status code, the page appears to be outdated & even has a message suggesting the same. The new site seems to have moved over here -https://python-gsoc.org/, should I update it?setup.rstneeds to be updated addresses for GitHub docs,ccachetohttps://ccache.dev/& the homepage for Visual Studio.triaging.rstagain couple of redirects but the link to "Python organization admin" under Becoming a member of the Python triage team directs tohttps://devguide.python.org/devcycle/?highlight=organization admin#current-ownerswhich can perhaps be improved to something like -https://devguide.python.org/devcycle/#organization-owner-policyorhttps://devguide.python.org/devcycle/#current-owners. Or is it better left as it is right now?These were the files @willingc specifically pointed out for fixing. But since the moment this issue thread was created, a couple of other files contain broken links as well. Do they need to be cleaned too?
I skimmed through briefly & found these documents requiring attention as well:
.github/CODE_OF_CONDUCT.md,buildbots.rst,buildworker.rst,committing.rst,communication.rst,coredev.rst,coverage.rst,devcycle.rst,documenting.rst,gitbootcamp.rst,help.rst,langchanges.rst,pullrequests.rst,runtests.rst,tracker.rst.I can take a look into these issues over the weekends & replace the older links to the newer redirected ones as per the following suggestions.
hunzlahmalik commentedon Mar 5, 2021
Working on developers.rst and setup.rst
Updated developers.rst python#371
Updated dead or redirected links (python#373)
hugovk commentedon Feb 11, 2023
Let's close this now,
make linkcheckfinds no problems.https://github.com/python/devguide/actions/runs/4150512884/jobs/7180218231#step:6:78
Thanks all for the contributions!