Skip to content

gh-158063: Fix out-of-bounds read when comparing decimal signal dicts #158069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lazerg wants to merge 1 commit into
base: main
Choose a base branch
from
Open

gh-158063: Fix out-of-bounds read when comparing decimal signal dicts #158069

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Lib/test/test_decimal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4026,6 +4026,9 @@ def test_flag_comparisons(self):
self.assertNotEqual(d, c.flags)
self.assertNotEqual(c.flags, d)

self.assertNotEqual(None, c.flags)
self.assertNotEqual(c.flags, None)

@requires_IEEE_754
def test_float_operation(self):
Decimal = self.decimal.Decimal
Expand Down
3 changes: 3 additions & 0 deletions Misc/NEWS.d/next/Library/2026-09-24-10-17-06.gh-issue-158063.Bx9Jpl.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Fix an out-of-bounds read in the C implementation of :mod:`decimal` when
comparing the ``flags`` or ``traps`` of a :class:`~decimal.Context` with an
object that is not a signal dict, such as ``None``.
3 changes: 2 additions & 1 deletion Modules/_decimal/_decimal.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -795,7 +795,8 @@ signaldict_richcompare(PyObject *v, PyObject *w, int op)
decimal_state *state = get_module_state_by_def(Py_TYPE(v));
assert(PyDecSignalDict_Check(state, v));

if ((SdFlagAddr(v) == NULL) || (SdFlagAddr(w) == NULL)) {
if ((SdFlagAddr(v) == NULL) ||
(PyDecSignalDict_Check(state, w) && SdFlagAddr(w) == NULL)) {
return value_error_ptr(INVALID_SIGNALDICT_ERROR_MSG);
}

Expand Down
Loading