Skip to content

gh-158063: Fix out-of-bounds read when comparing decimal signal dicts - #158069

Open
lazerg wants to merge 1 commit into
python:mainfrom
lazerg:fix-issue-158063
Open

lazerg wants to merge 1 commit into
python:mainfrom
lazerg:fix-issue-158063

Conversation

@lazerg

@lazerg lazerg commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

signaldict_richcompare() checked SdFlagAddr(w) before it knew w was a signal dict, so comparing flags or traps with anything else (e.g. None) read the flags pointer from past the end of that object. The NULL check on w now only runs when w is a signal dict. Other objects fall through to the existing dict/NotImplemented handling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant