Skip to content

Some Unicode format specifiers are incorrect #146615

Closed
Closed
Some Unicode format specifiers are incorrect#146615
Labels
extension-modulesC modules in the Modules dirinterpreter-core(Objects, Python, Grammar, and Parser dirs)type-bugAn unexpected behavior, bug, or error

Description

@sunmy2019
sunmy2019
opened on Mar 29, 2026

Bug report

Bug description:

Inspired by #146578, I wrote a checker to check all unicode format strings.

There are 2 kinds of errors.

  1. There are ~8 real mistakes.
  2. Comply with C99 for va_list: https://en.cppreference.com/w/c/variadic/va_arg.html
    Most of the changes are %d <-> %ld for int and Py_ssize_t.

I opened an draft PR #146616 containing only the fixes to display what could be changed. We can discuss and cherry pick some fixes in that PR.

CPython versions tested on:

CPython main branch

Operating systems tested on:

Linux

Linked PRs

Activity

  1. sunmy2019
    added
    type-bugAn unexpected behavior, bug, or error
    on Mar 29, 2026
  2. sunmy2019
    added a commit that references this issue on Mar 29, 2026

    Merge branch 'main' into pythongh-146615

    c155ca4
  3. picnixz
    added
    interpreter-core(Objects, Python, Grammar, and Parser dirs)
    extension-modulesC modules in the Modules dir
    on Mar 29, 2026

  4. serhiy-storchaka commented on Mar 30, 2026

    @serhiy-storchaka
    serhiy-storchaka
    on Mar 30, 2026
    Member

    Wow, there were so many of them! No way we could pick all of them one by one. Thank you for your great work, @sunmy2019.

  5. sunmy2019
    added a commit that references this issue on Mar 30, 2026

    Merge branch 'main' into pythongh-146615-5

    030e077
  6. serhiy-storchaka
    added a commit that references this issue on Mar 31, 2026

    gh-146615: Fix crash in __get__() for METH_METHOD descriptors with in…

    72d29ea
  7. miss-islington
    added 2 commits that reference this issue on Mar 31, 2026

    pythongh-146615: Fix crash in __get__() for METH_METHOD descriptors w…

    ceacec7

    pythongh-146615: Fix crash in __get__() for METH_METHOD descriptors w…

    20c327a
  8. serhiy-storchaka
    added 2 commits that reference this issue on Mar 31, 2026

    gh-146615: Fix format specifiers in extension modules (GH-146617)

    1c396e1

    gh-146615: Fix format specifiers in test cextensions (GH-146618)

    b705553
  9. miss-islington
    added a commit that references this issue on Mar 31, 2026

    pythongh-146615: Fix format specifiers in test cextensions (pythonGH-…

    985a482
  10. serhiy-storchaka
    added a commit that references this issue on Mar 31, 2026

    gh-146615: Fix format specifiers in Python/ directory (GH-146619)

    dcb260e
  11. miss-islington
    added a commit that references this issue on Mar 31, 2026

    pythongh-146615: Fix format specifiers in Python/ directory (pythonGH…

    7a30be3
  12. serhiy-storchaka
    added a commit that references this issue on Mar 31, 2026

    gh-146615: Fix format specifiers in Objects/ directory (GH-146620)

    bbf7fb2

  13. 22 remaining items

  14. vstinner
    added a commit that references this issue on Apr 1, 2026

    [3.14] gh-146615: Fix format specifiers in extension modules (GH-146617…

    b406d85
  15. sunmy2019
    added a commit that references this issue on Apr 1, 2026

    Merge branch '3.13' into pythongh-146615-7

    86f4a4e
  16. vstinner
    added a commit that references this issue on Apr 1, 2026

    [3.13] gh-146615: Fix format specifiers in Objects/ directory (GH-146620

    c0eae2a

  17. vstinner commented on Apr 7, 2026

    @vstinner
    vstinner
    on Apr 7, 2026
    Member

    I added 2 PRs for what is missing.

    These two last PRs have been merged, so I close the issue. Thanks @sunmy2019 for your fixes!

  18. vstinner
    closed this as completedon Apr 7, 2026
  19. clin1234
    added 5 commits that reference this issue on Apr 16, 2026

    pythongh-146615: Fix crash in __get__() for METH_METHOD descriptors w…

    3743101

    pythongh-146615: Fix format specifiers in extension modules (pythonGH…

    de13cd4

    pythongh-146615: Fix format specifiers in test cextensions (pythonGH-…

    653497e

    pythongh-146615: Fix format specifiers in Python/ directory (pythonGH…

    5b52651

    pythongh-146615: Fix format specifiers in Objects/ directory (pythonG…

    574c009
  20. ljfp
    added 5 commits that reference this issue on Apr 25, 2026

    pythongh-146615: Fix crash in __get__() for METH_METHOD descriptors w…

    909f42f

    pythongh-146615: Fix format specifiers in extension modules (pythonGH…

    b2573b8

    pythongh-146615: Fix format specifiers in test cextensions (pythonGH-…

    f8a40bb

    pythongh-146615: Fix format specifiers in Python/ directory (pythonGH…

    ee13941

    pythongh-146615: Fix format specifiers in Objects/ directory (pythonG…

    07c785e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    extension-modulesC modules in the Modules dirinterpreter-core(Objects, Python, Grammar, and Parser dirs)type-bugAn unexpected behavior, bug, or error

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions