Repository navigation
_zstd: Fix printf format for pledged size errors #146578
Description
Activity
I can confirm that the exception message is currently formatted incorrectly (note the trailing
ll):>>> compression.zstd.ZstdCompressor().set_pledged_input_size(2**64) Traceback (most recent call last): File "<python-input-1>", line 1, in <module> compression.zstd.ZstdCompressor().set_pledged_input_size(2**64) ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^ ValueError: size argument should be a positive int less than 4294967294ll
Problem
In
zstd_contentsize_converter(Modules/_zstd/compressor.c), ValueError messages use the format specifier%ullwhen printingZSTD_CONTENTSIZE_ERROR. The correct C99 format forunsigned long longis%llu;%ullis invalid.Proposed fix
Replace
%ullwith%lluin both error paths.Linked PRs