Skip to content

Add threading support based on wasi-threads #101538

Closed

Description

@yamt

Activity

  1. added 2 commits that reference this issue on Feb 3, 2023
  2. brettcannon commented on Feb 10, 2023

    @brettcannon
    Member

    My concerns about supporting this is that wasi-threads is only at phase 1 of (I believe) 4, so this is not close to being available publicly as part of WASI itself.

    The WASI SDK support is also not released yet (although I see the OP is the author of the support that's in their main branch 😉). I also don't know how many WASI runtimes support this proposal (e.g. wasmtime doesn't, but does wasmer, wasmedge, iwasm/WAMR, etc.?). Basically this seems very experimental and I would prefer we were not providing direct support and thus the ones that will get the bug reports on the feature.

    As such, I'm unfortunately going to need to reject this feature request. Maybe Singlestore Labs or VMWare via their builds would be up for taking this on? Otherwise I would suggest keeping a fork going with your changes and release your own build if you're trying to get testing for wasi-threads specifically.

  3. yamt commented on Feb 11, 2023

    @yamt
    ContributorAuthor

    My concerns about supporting this is that wasi-threads is only at phase 1 of (I believe) 4, so this is not close to being available publicly as part of WASI itself.

    The WASI SDK support is also not released yet (although I see the OP is the author of the support that's in their main branch 😉). I also don't know how many WASI runtimes support this proposal (e.g. wasmtime doesn't, but does wasmer, wasmedge, iwasm/WAMR, etc.?). Basically this seems very experimental and I would prefer we were not providing direct support and thus the ones that will get the bug reports on the feature.

    wasmtime support has been landed in the meantime.
    wamr has a support on a dev branch.

    As such, I'm unfortunately going to need to reject this feature request. Maybe Singlestore Labs or VMWare via their builds would be up for taking this on? Otherwise I would suggest keeping a fork going with your changes and release your own build if you're trying to get testing for wasi-threads specifically.

  4. brettcannon commented on Feb 11, 2023

    @brettcannon
    Member

    We can re-evaluate once wasi-sdk has support in a release.

  5. yamt commented on Feb 17, 2023

    @yamt
    ContributorAuthor

    a prerelease of wasi-sdk with wasi-threads support: https://github.com/WebAssembly/wasi-sdk/releases/tag/wasi-sdk-20%2Bthreads

  6. yamt commented on Apr 3, 2023

    @yamt
    ContributorAuthor

    We can re-evaluate once wasi-sdk has support in a release.

    now a wasi-sdk release with wasi-threads is available: https://github.com/WebAssembly/wasi-sdk/releases/tag/wasi-sdk-20

  7. brettcannon commented on Apr 3, 2023

    @brettcannon
    Member

    The "experimental support" and "use at your own risk" parts of the release notes at https://github.com/WebAssembly/wasi-sdk/releases/tag/wasi-sdk-20 are still not enough for me to be willing to take on the support burden of keeping wasi-threads working in main.

  8. added a commit that references this issue on Jun 22, 2023
  9. added a commit that references this issue on Jun 23, 2023
  10. added a commit that references this issue on Jul 17, 2023
  11. added a commit that references this issue on Jul 17, 2023
  12. brettcannon commented on Oct 19, 2023

    @brettcannon
    Member

    Threading support is in, so closing (although it's currently broken; see #111046).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions