Skip to content

Fix threaded build under WASI #111046

Closed
Closed
Fix threaded build under WASI#111046
Labels
OS-wasibuildThe build process and cross-buildtype-bugAn unexpected behavior, bug, or error

Description

@brettcannon
brettcannon
opened on Oct 18, 2023

Bug report

Bug description:

https://bytecodealliance.zulipchat.com/#narrow/stream/217126-wasmtime/topic/.60missing.20required.20memory.20export.60.20for.20threaded.20CPython/near/397361259

I think you'll want -Wl,--export-memory (the --export-memory to wasm-ld) to get past that check; threaded modules for WASI need to both import and export their memory right now.

CPython versions tested on:

3.12

Operating systems tested on:

Other

Linked PRs

Activity

  1. brettcannon
    added
    type-bugAn unexpected behavior, bug, or error
    buildThe build process and cross-build
    OS-wasi
    on Oct 18, 2023

  2. brettcannon commented on Oct 19, 2023

    @brettcannon
    brettcannon
    on Oct 19, 2023
    MemberAuthor

    Probably need to change the following line to include --export-memory:

    cpython/configure.ac

    Line 2168 in c9aef19

    AS_VAR_APPEND([LDFLAGS_NODIST], [" -Wl,--import-memory"])

  3. brettcannon
    added a commit that references this issue on Oct 20, 2023

    gh-111046: for wasi-threads, export memory as well via the linker (GH…

    5dfa717
  4. miss-islington
    added a commit that references this issue on Oct 20, 2023

    pythongh-111046: for wasi-threads, export memory as well via the link…

    aafa2ec
  5. brettcannon
    closed this as completedon Oct 20, 2023
  6. brettcannon
    added a commit that references this issue on Oct 20, 2023

    [3.12] gh-111046: for wasi-threads, export memory as well via the lin…

    727f8ee
  7. aisk
    added a commit that references this issue on Feb 11, 2024

    pythongh-111046: for wasi-threads, export memory as well via the link…

    701f274
  8. Glyphack
    added a commit that references this issue on Sep 2, 2024

    pythongh-111046: for wasi-threads, export memory as well via the link…

    8c8fd5a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    OS-wasibuildThe build process and cross-buildtype-bugAn unexpected behavior, bug, or error

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions