Skip to content

Issue #419: Only add Tier-1 and Tier-2 builders to Release Status #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ambv merged 2 commits into from
Oct 11, 2023
Merged

Issue #419: Only add Tier-1 and Tier-2 builders to Release Status #422

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d74e335
Issue #419: Only add Tier-1 and Tier-2 builders to Release Status
vstinner Oct 11, 2023
857a722
Fix missing import
vstinner Oct 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions master/custom/builders.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,17 @@
Wasm32WASIBuild,
)

# A builder can be marked as stable when at least the 10 latest builds are
# successful, but it's way better to wait at least for at least one week of
# successful builds before considering to mark a builder as stable.
STABLE = "stable"

# New builders should always be marked as unstable. If a stable builder starts
# to fail randomly, it can be downgraded to unstable if it is not a Tier-1 or
# Tier-2 builder.
UNSTABLE = "unstable"

# https://peps.python.org/pep-0011/ defines Platfom Support Tiers
TIER_1 = "tier-1"
TIER_2 = "tier-2"
TIER_3 = "tier-3"
Expand Down
7 changes: 6 additions & 1 deletion master/master.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ from custom.builders import (
STABLE,
DAILYBUILDERS,
ONLY_MAIN_BRANCH,
TIER_1, TIER_2,
) # noqa: E402

def set_up_sentry():
Expand Down Expand Up @@ -198,6 +199,7 @@ def is_important_change(change):


github_status_builders = []
release_status_builders = []
mail_status_builders = []

# Regular builders
Expand Down Expand Up @@ -252,6 +254,9 @@ for branch_num, (git_url, branchname, git_branch) in enumerate(git_branches):
# disable GitHub notifications for unstable builders
if stability == STABLE:
github_status_builders.append(buildername)
# Only Tier-1 and Tier-2 builders can block a release
if tier in (TIER_1, TIER_2):

@ambv ambv Oct 11, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

builtins.NameError: name 'TIER_1' is not defined

@vstinner vstinner Oct 11, 2023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed ;-)

release_status_builders.append(buildername)
tags = [branchname, stability,] + getattr(f, "tags", [])
if tier:
tags.append(tier)
Expand Down Expand Up @@ -521,7 +526,7 @@ c['www']['plugins']['wsgi_dashboards'] = [
{
'name': 'release_status',
'caption': 'Release Status',
'app': get_release_status_app(github_status_builders),
'app': get_release_status_app(release_status_builders),
'order': 2,
'icon': 'rocket'
}
Expand Down