Skip to content

Issue #419: Only add Tier-1 and Tier-2 builders to Release Status - #422

Merged
ambv merged 2 commits into
python:mainfrom
vstinner:release_status_tier
Oct 11, 2023
Merged

ambv merged 2 commits into
python:mainfrom
vstinner:release_status_tier

Conversation

@vstinner

Copy link
Copy Markdown
Member

No description provided.

@vstinner

Copy link
Copy Markdown
Member Author

cc @ambv @pablogsal @zware

Comment thread master/master.cfg
if stability == STABLE:
github_status_builders.append(buildername)
# Only Tier-1 and Tier-2 builders can block a release
if tier in (TIER_1, TIER_2):

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

builtins.NameError: name 'TIER_1' is not defined

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed ;-)

@ambv
ambv merged commit c51d56f into python:main Oct 11, 2023
@vstinner
vstinner deleted the release_status_tier branch October 11, 2023 13:40
@vstinner

Copy link
Copy Markdown
Member Author

Thanks for the review @ambv.

@itamaro

itamaro commented Oct 11, 2023

Copy link
Copy Markdown
Contributor

Does this change affect the release manager workflow? Are all RMs aware?

@vstinner

Copy link
Copy Markdown
Member Author

cc @pablogsal @Yhg1s @ambv: I fixed https://buildbot.python.org/all/#/release_status page to only list buildbot builders of Tier-1 and Tier-2. Builders of Tier-3 or with no Tier must not block a release and so are no longer listed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants