You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Custom preferences.txt location not working in Processing 4.5.2 #1435
@avinxshKD Hey, thanks for wanting to help out again
Just a heads-up: as we discussed on #1433, commenting "please assign" without a proposed approach or investigation into the issue goes against our contribution guidelines which ask that you include a brief explanation of how you'd tackle the problem before requesting assignment.
I totally understand college keeps you busy. Just know that consistently skipping the process creates extra work for maintainers and isn't fair to other contributors either. Quality over quantity 😉
If you're interested in this issue, a great next step would be try reproducing the issue, dig into the codebase for the cause of the bug, and share your findings and proposed fix here. That kind of contribution is always welcome!
Hey @SableRaf, you're absolutely right and I apologize. I got caught up in the excitement of wanting to contribute and skipped the actual work. And yeah college has been hectic but that's no excuse for skipping the process. That's on me, so sorry
i looked into it and yeah it's broken. the new kotlin preferences code (Preferences.kt line 84) just calls Settings.getFolder() directly instead of checking if theres a settings override first. the old java version used to check Base.getSettingsOverride() before grabbing the default folder. so settings.txt gets read on startup but then preferences get saved to appdata anyway
fix should be pretty simple - justn check the override first:
val settingsFolder = Base.getSettingsOverride() ?: Settings.getFolder()
can test it with the steps from the issue report if you want me to make a pr. will do the homework first next time, thanks
@avinxshKD I have assigned you. I'll let @catilac comment on the proposed technical solution and next steps as this is outside of my area of competence 😌
Activity
avinxshKD commentedon Feb 16, 2026
I'd like to work on this, pls assign
SableRaf commentedon Feb 16, 2026
@avinxshKD Hey, thanks for wanting to help out again
Just a heads-up: as we discussed on #1433, commenting "please assign" without a proposed approach or investigation into the issue goes against our contribution guidelines which ask that you include a brief explanation of how you'd tackle the problem before requesting assignment.
I totally understand college keeps you busy. Just know that consistently skipping the process creates extra work for maintainers and isn't fair to other contributors either. Quality over quantity 😉
If you're interested in this issue, a great next step would be try reproducing the issue, dig into the codebase for the cause of the bug, and share your findings and proposed fix here. That kind of contribution is always welcome!
avinxshKD commentedon Feb 16, 2026
Hey @SableRaf, you're absolutely right and I apologize. I got caught up in the excitement of wanting to contribute and skipped the actual work. And yeah college has been hectic but that's no excuse for skipping the process. That's on me, so sorry
i looked into it and yeah it's broken. the new kotlin preferences code (Preferences.kt line 84) just calls Settings.getFolder() directly instead of checking if theres a settings override first. the old java version used to check Base.getSettingsOverride() before grabbing the default folder. so settings.txt gets read on startup but then preferences get saved to appdata anyway
fix should be pretty simple - justn check the override first:
val settingsFolder = Base.getSettingsOverride() ?: Settings.getFolder()can test it with the steps from the issue report if you want me to make a pr. will do the homework first next time, thanks
SableRaf commentedon Feb 17, 2026
@avinxshKD I have assigned you. I'll let @catilac comment on the proposed technical solution and next steps as this is outside of my area of competence 😌
catilac commentedon Feb 17, 2026
amazing thank you @SableRaf and @avinxshKD :) i'll be taking a look at the PR
avinxshKD commentedon Feb 18, 2026
hey super thanks, pr is ready you can review and
let me know if any adjustments needed, happy to