Repository navigation
fix(image): capture collector:user's output in the smoke test, and roadmap notes - #89
Merged
Merged
Conversation
…smoke test (#19) The collector:user check still piped the task into grep -q, the shape #19 names: under pipefail, a grep that ends at its first match can fail the pipeline. It now captures the output, fails with it if the task exits non-zero, then asserts the whole line "Created admin smoke@example.com." and shows what it got when the line is missing. No check in the script pipes into grep -q now. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The check rejects anything in /rails/vendor besides .keep, javascript and ocr; it does not require them, so an empty listing passes. Its heading said "holds only". It now says "nothing unexpected", and a comment says that the OCR files served above are what show ocr is there. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ekeeping lane Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three touch-ups from the review of PR #82 that were committed after it merged, plus the roadmap notes that PR couldn't carry.
What changed
bin/image-smoke, thecollector:usercheck. It still piped intogrep -q, the pattern Tighten bin/image-smoke's catalog:status check #19 named forcatalog:status. It now captures the task's output and tests for the whole lineCreated admin smoke@example.com., and shows what it got on failure. One new example inspec/image_publishing_spec.rb, seen failing first.bin/image-smoke, the/rails/vendorcheck's wording. It rejects extras only (an empty listing passes; the OCR files served just above showocris there), so it now says "nothing unexpected", not "holds only".verification.md. Records PR fix(image): one OCR engine per image, and an exact smoke check #82's run (ci and both image jobs green on921c631) as the CI evidence for Tighten bin/image-smoke's catalog:status check #19 and Local image builds contain the OCR engine twice (/rails/vendor/v7.0.0) #31, that the failure paths were shown with a stand-in CLI, and that the local image runs were podman on amd64 only.docs/roadmap.md, housekeeping lane. Tighten bin/image-smoke's catalog:status check #19 and Local image builds contain the OCR engine twice (/rails/vendor/v7.0.0) #31 marked done by PR fix(image): one OCR engine per image, and an exact smoke check #82; Admin catalog shows raw exception classes when a refresh or build fails #84 and Rate-limit retries count over a job's whole life, so a long build can run out #86 listed.Verification
bin/ci: passed on the rebased branch (1352 examples, 0 failures, 1 pending, the art agreement spec); the roadmap line for Rate-limit retries count over a job's whole life, so a long build can run out #86 was amended in afterwards, and the pre-push run passed.collector:usercheck passed against the published0.2.1image and failed, printing the task's output, when a stand-in CLI rewrote its line. No image was rebuilt.Notes
🤖 Generated with Claude Code