Repository navigation
feat(021): mark an unowned tile with words, not a faded image - #88
Merged
Merged
Conversation
Ruling (maintainer, 2026-10-13): of four rendered looks, D was chosen: the card image at full opacity with a visible "Not owned" tag below it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A c-tag on a second c-tile__meta row, the last thing inside the tile's link, in search results and on a card's printings page (#65). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…evel Overrides the export's 45% fade on c-tile--owned-none in additions.css, for the image and the missing-image fallback, and puts the add control at the foot of its cell so a row that mixes owned and unowned tiles stays level. Scryfall's image guideline forbids desaturating or color-shifting a card image (#65; ruling of 2026-10-13, look D). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…after an add From the branch review: the phone-width rows are mixed whatever the factories' sequences hold; the stylesheet check also reads rules inside a media query; quick add asserts the marker before the add and not after. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Six images, about 440 KB in all (2.1 MB before): after at 1280px and 390px in both themes, before at 1280px in both themes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ng variable A comment that names a filter above a tile rule no longer fails the check. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… document TileAdd.md is an app addition (spec 004), not part of the export, and never described the fade; only ItemTile.md does. UnownedTile.md says so and points at TileAdd for the foot-of-cell rule. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… v1.1.0) The direction is approved by the maintainer's ruling of 2026-10-13; decisions 2 to 8 are put to the maintainer in the pull request. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tile of a card you don't own now shows the card image exactly as supplied, with a visible "Not owned" marker below it, instead of the image at 45% opacity.
Closes #65
Why
Scryfall's image guidelines say "Do not blur, sharpen, desaturate, or color-shift card images." A faded image blends with the page behind it. The maintainer compared four rendered looks on 2026-10-13 and chose this one (spec 021, decision 1).
What changed
collector/additions.cssreturns the unowned tile's image and its no-image placeholder to full opacity.components.cssis the design-system export and isn't edited; the override wins by stylesheet order.catalog/entries/_tileadds a "Not owned"c-tagon a row of its own under the set and language tags, inside the link, so a screen reader hears it as part of the tile's name. Nothing is laid over the image.docs/design-system/components/UnownedTile.md, and a bullet inTileAdd.md. The export'sItemTile.mdstill describes the fade;UnownedTile.mdsays the published design system should drop it at its next export, when the override can go.Screenshots
Decisions for you
The ruling settles the look. These were the implementer's to make and are recorded in spec 021 as decisions 2 to 8; the main ones:
c-tag, not a pattern of its own.Chip.mddescribes the tag as "for data"; the scanner already uses one for a status phrase.×Nquantity badge on the image counts as a "stamp" under the same guideline.Verification
bin/ci: passed, 1354 examples, 0 failures, 1 pending (the art agreement spec, unrelated).spec/design_system_files_spec.rbnow fails on any new rule that fades or filters ac-tile. It pins the export'sopacity:.45, so a corrected re-export needs that expectation edited.Known limits
docs/roadmap.mdstill lists Decide whether fading unowned card tiles fits Scryfall's image guidelines #65 as waiting for a ruling.🤖 Generated with Claude Code