Repository navigation
scratch: spec 056 AC-4.2 probe (do not merge) - #285
Closed
plainprogrammer wants to merge 49 commits into
Closed
plainprogrammer wants to merge 49 commits into
plainprogrammer wants to merge 49 commits into
Conversation
…264) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…D, namespaces, extents) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
… review folded in) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
RED: 39 examples, 8 failures (edited body, removed lines, reformat, opening edit, nested class edit, rename plus edit, comment deletion and the two-file class), as Phase 1 knows only added. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…ith the base (spec 056) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
… 056) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…less checkout, and run as a command (spec 056) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…c 056) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…se-and-deploy area doc (spec 056) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…unchanged one is ignored (spec 056 AC-3.4) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…allback (spec 056 AC-3.4) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…on has a summary, in either file order (spec 056 decision 4) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…nitions has a summary (spec 056 decision 4) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…(spec 056) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…es (spec 056) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
… with a namespace's api private (spec 056 decision 3) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…and Snapshot.build cleans up after an exception (spec 056) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…spec 056) Found in the Opus code review of the implementation; YARD passes the tag down to the members it scopes under the object. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…mary (spec 056 AC-1.4) Red: a file that opens with a magic comment or a shebang passes the check with an uncommented class, because the class fallback reads those lines. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…t its summary (spec 056 AC-1.4) The class and module reading of the raw comment lines now drops leading shebang and magic comment lines, and so does the check of YARD's docstring, since YARD itself keeps warn_indent and similar comments as docstring text. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…d base (spec 056 AC-1.13) The base's file now opens module Collector with no comment, so the example fails if a reopened namespace is judged (checked against a scratch copy of the script whose change rule changes every reopened namespace). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…sibility directive exempts methods Probed in a throwaway repository: with a free-standing @!visibility private directive before two methods, both were judged. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…on a namespace (PATCH) Confirmed by the maintainer on 2026-11-10 via the coordinator. The spec now says what the approved plan's design and the code do: a method is new by qualified name across the base's scoped files (a move between files of the same class is not judged), and a class or module marked @api private covers its members. No ruling changed. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…te on a class covers its members (spec 056 v1.2.3) Characterization of behaviour spec 056 v1.2.3 now states and the code already has, so there is no RED step; each example passes at once. Each was shown able to fail by temporarily mutating script/yard/comment_ratchet.rb (restored): - Moved method (decision 4): making `change` return :added when the base's item is in another file fails it (A#x reported "(added)" instead of passing, and "(added)" instead of "(changed)" for the edited copy). - @api private on a class (decision 3, AC-1.10): reading the tag from the object's own docstring text instead of YARD's `object.tag(:api)`, which looks through the enclosing namespaces, fails both examples (Internal#a, Inner and Inner#b are judged). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…ith the normal line instead of crashing (spec 056 AC-3.1) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…c 056 AC-3.1) The ratchet ran YARD::DocstringParser on a definition's raw comment, which executes a @!parse directive and re-parses its code into the live registry from (stdin) while the snapshot walks it, so a class whose only comment was such a directive crashed the check with Errno::ENOENT. The text before the first line starting with @ is now cut by hand: a directive is not summary text. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…d the Mode B verdicts Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…ocess (spec 056 loads YARD in-process)
Ruling: spec 056's in-process examples stay as they are; spec 054's AC-3.7
example checks what it means (booting the app does not load YARD) in a fresh
process, so it no longer depends on what other examples loaded.
Cause: spec/script/yard/comment_ratchet_spec.rb requires
script/yard/comment_ratchet.rb, which does `require "yard"`, so YARD is
defined in the RSpec process once that file has run. The plan assumed another
spec already did this; none does.
RED (bin/rspec spec/script/yard/comment_ratchet_spec.rb
spec/project_config_spec.rb --order defined, 91 examples, 1 failure):
Worktree project configuration YARD (spec 054) keeps the extension and YARD
out of the app's boot (AC-3.7)
expected: nil
got: "constant"
The example now runs `RAILS_ENV=test bin/rails runner "print
defined?(YARD).inspect"` and expects "nil" (about 0.8 s). With
RUBYOPT=-ryard it fails with "booting the app loaded YARD", so it still
detects a YARD loaded at boot. The Rails.autoloaders expectation is unchanged.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…eded runs, and the AC-3.7 ruling Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
… scratch; never merge) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…tchet (spec 056) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…(spec 027 D4) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
# Conflicts: # docs/specs/README.md
# Conflicts: # docs/specs/README.md
# Conflicts: # docs/specs/README.md
# Conflicts: # docs/specs/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Throwaway probe for spec 056 AC-4.2: an uncommented public method. The checks job must fail at the step 'Docs: new and changed public code has a comment', naming lib/collector/dev_port.rb. Closed after the run.