Repository navigation
Hooks run Ruby through mise; system specs pin classic scrollbars (#270, #271) - #272
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…h_mise (#270) A session Orca starts has macOS's Ruby 2.6 first on its PATH, so the pre-commit hook's Brakeman failed and blocked every commit. The three hooks that run Ruby now go through script/worktree/with_mise --optional, which picks .ruby-version's Ruby where mise exists and changes nothing on CI or in cloud sessions. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
On a Mac with no mouse connected, Firefox draws overlay scrollbars, which widen a narrow frame by 15px; spec 048 AC-1.8's 360px wrap then fails locally while CI stays green. Pin ui.useOverlayScrollbars = 0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #270 and #271. Every Orca worker was blocked from committing or pushing by these two problems, so they ship together.
#270: the hooks run Ruby through
script/worktree/with_mise --optional. A Claude Code session that Orca starts has macOS's Ruby 2.6 first on its PATH. Its pre-commit hook's Brakeman therefore failed ("Could not find bundler 4.0.20") and blocked every commit. The three hooks that run Ruby now go throughwith_mise --optional: after-edit RuboCop, pre-commit RuboCop and Brakeman, and the pre-pushpre_push_ci.rb, which then runsbin/cion the same Ruby. Where mise isn't installed (CI, cloud sessions), they run the command unchanged.spec/config/ci_definition_spec.rbgains two examples that check each hook does this. Committed first and failing, then passing.PATH=/usr/bin:/bin:/usr/sbin:/sbin: the old commit hook fails in Brakeman on Ruby 2.6 and blocks; the new one prints "No warnings found" and exits 0. The pre-push hook's runner givesruby 4.0.7.#271: system specs pin classic scrollbars. On a Mac with no mouse connected, Firefox draws overlay scrollbars. That widens a narrow frame by 15px, so
collection_row_place_spec.rb:93(spec 048 AC-1.8) failed every local run while CI stayed green.spec/support/system.rbnow setsui.useOverlayScrollbars = 0, as #118 pinned the colour scheme. The file passes locally again: 18 examples, 0 failures. #271 notes that AC-1.8's 360px wrap doesn't hold on a real phone; that's for a later spec.The pre-push
bin/cipassed at the pushed head, run through the new hook.🤖 Generated with Claude Code