Repository navigation
Conversation
kocsismate
left a comment
kocsismate
left a comment
There was a problem hiding this comment.
And please add a test case in zend_test
| @@ -2369,7 +2369,7 @@ function parseFunctionLike( | |||
| function parseProperty( | |||
| Name $class, | |||
| int $flags, | |||
| Stmt\PropertyProperty $property, | |||
| Stmt\PropertyProperty|Node\Param $property, | |||
There was a problem hiding this comment.
We aim for PHP 7.1 compatibility, so union types shouldn't be used.
There was a problem hiding this comment.
I do not understand. PHP-7 is in security-fix-only mode, so this PR is not going to land in PHP-7.
There was a problem hiding this comment.
Yeah, but one can run gen_stubs.php via an earlier PHP version: e.g. I always use the version which is available on my the system (it's 8.0 in my case though).
There was a problem hiding this comment.
No, it's not a negligible issue: gen_stub.php is automatically run by the build system during compilation via the php executable which is on path.
There was a problem hiding this comment.
So, what do you suggest? A runtime check for instanceof Stmt\PropertyProperty or Node\Param?
There was a problem hiding this comment.
IMO a phpdoc would be enough, just like we did elsewhere, but I'm OK with a runtime check as well.
This reverts commit ad5021b944d388cb0676946b227d72e66a4638d1.
930889a to
d60b561
Compare
|
What's the status here? |
Kinda stuck. I'll have to find my most current stash and update it... |
3 participants
Uh oh!
There was an error while loading. Please reload this page.