Repository navigation
Conversation
Contributor
|
PHP's test didn't passed in Travis as travisbot reported. currently, it seems useless :( |
Member
|
It would be nice to get a clean build before adding any more stuff. Right now Travis isn't particularly helpful as it always fails ^^ |
Contributor
Author
|
Sure, we need a clean build but it should be clean for all build-in functions. Else we could disable other failed extensions to get a clean build but this doesn't help. Travis should run all possible test and the bugs/tests should be fixed instead of ignoring tests. |
Contributor
|
Comment on behalf of lstrojny at php.net: Closing for now |
heyJordanParker
added a commit
to heyJordanParker/php-sharp
that referenced
this pull request
Oct 13, 2026
Problem php#164 made analyze_constructor_initializer stop with unreachable! when no class is in scope. Master returns Ok there. php#157 did not fold an unreachable! into that guard, so this was no restore. The claim that only a method passes an initializer was read, not run, and a wrong unreachable! there would crash a user's whole compile. Solution The function is master's code again. crates/analyzer/src/statement/class_like/method.rs <- analyze_constructor_initializer as on master
heyJordanParker
added a commit
to heyJordanParker/php-sharp
that referenced
this pull request
Oct 13, 2026
ci: patch-coverage leaves out lines where only unreachable! runs
heyJordanParker
added a commit
to heyJordanParker/php-sharp
that referenced
this pull request
Oct 13, 2026
Problem: PR php#152 must be up to date with master. Master gained php#164, which leaves `unreachable!` lines out of patch-coverage. It also gained php#163, which adds List insert, remove and clear, and php#165, which fixes a project with a law that compiles twice. php#163's `takes_operands` calls `ComparisonResult::with_sharp_rules(true)`, which this branch replaced in its php#129 merge, so the merged tree did not compile. Solution: merge master. Git merged every file on its own. `takes_operands` builds its result with `ComparisonResult::for_dialect(Dialect::Sharp)`, the branch's one constructor path. Master's `with_sharp_rules(true)` made the same result. The analyzer, semantics, bridge and names suites and the root compile tests pass on the merged tree, and clippy reports nothing. crates/ ├── analyzer/src/expression/binary/utils.rs for_dialect(Dialect::Sharp) in takes_operands ├── analyzer/src/expression/call/method_call.rs master's search runs after the call's type is known ├── names/src/lib.rs master's insert, remove and clear └── sharp-bridge/ master's List changes beside this branch's checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables travis tests of ext/dba with the handlers inifile (buildin), flatfile (buildin), cdb (buildin), gdbm and tcadb.
I also would like to add --with-db4 but can't compile :( - see http://travis-ci.org/#!/marc-mabe/php-src/builds/2138877