Repository navigation
Fixed Mcrypt Deprecated functions and tests - #163
Closed
srgoogleguy wants to merge 2 commits into
Closed
srgoogleguy wants to merge 2 commits into
srgoogleguy wants to merge 2 commits into
Conversation
heyJordanParker
added a commit
to heyJordanParker/php-sharp
that referenced
this pull request
Oct 13, 2026
feat: List insert, remove and clear, changing the list where it lives
heyJordanParker
added a commit
to heyJordanParker/php-sharp
that referenced
this pull request
Oct 13, 2026
…able php#163 rewrote check_element_equality to compare an element with the value and carried the debug_assert! fold forward. The merge keeps php#163's code and its separate Instance arm, and the unreachable! arm for Identity, NullableOperand and UnorderedOperand, which sharp_refusal never returns for ==.
heyJordanParker
added a commit
to heyJordanParker/php-sharp
that referenced
this pull request
Oct 13, 2026
Problem: PR php#152 must be up to date with master. Master gained php#164, which leaves `unreachable!` lines out of patch-coverage. It also gained php#163, which adds List insert, remove and clear, and php#165, which fixes a project with a law that compiles twice. php#163's `takes_operands` calls `ComparisonResult::with_sharp_rules(true)`, which this branch replaced in its php#129 merge, so the merged tree did not compile. Solution: merge master. Git merged every file on its own. `takes_operands` builds its result with `ComparisonResult::for_dialect(Dialect::Sharp)`, the branch's one constructor path. Master's `with_sharp_rules(true)` made the same result. The analyzer, semantics, bridge and names suites and the root compile tests pass on the merged tree, and clippy reports nothing. crates/ ├── analyzer/src/expression/binary/utils.rs for_dialect(Dialect::Sharp) in takes_operands ├── analyzer/src/expression/call/method_call.rs master's search runs after the call's type is known ├── names/src/lib.rs master's insert, remove and clear └── sharp-bridge/ master's List changes beside this branch's checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the rest of the Mcrypt functions that were deprecated but not defined as such: mcrypt_ofb, mcrypt_cbc, mcrypt_cfb. This also fixes all the related tests. This should have originally been done in pull 141 #141
Sorry for the delay.