Skip to content

remove dead code and unused imports - #25763

Merged
DeepDiver1975 merged 1 commit into
masterfrom
minor_dav_cleanup
Aug 12, 2016
Merged

DeepDiver1975 merged 1 commit into
masterfrom
minor_dav_cleanup

Conversation

@butonic

@butonic butonic commented Aug 10, 2016

Copy link
Copy Markdown
Contributor

Two services reference classes that no longer exist ... I ran a quick inspection and removed other unused imports in the dav app.

@DeepDiver1975

@mention-bot

Copy link
Copy Markdown

@butonic, thanks for your PR! By analyzing the annotation information on this pull request, we identified @DeepDiver1975, @LukasReschke and @PVince81 to be potential reviewers

@butonic
butonic force-pushed the minor_dav_cleanup branch from 5b35cf0 to 1ccbfbe Compare August 11, 2016 14:47
@PVince81

Copy link
Copy Markdown
Contributor

👍 but I'd like @DeepDiver1975 to confirm the service removals regarding birthday

@phsc84 phsc84 mentioned this pull request Aug 12, 2016
59 of 67 tasks
);
});

$container->registerService('OCA\DAV\Migration\Classification', function ($c) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@DeepDiver1975

Copy link
Copy Markdown
Contributor

👍

@DeepDiver1975
DeepDiver1975 merged commit f91cc78 into master Aug 12, 2016
@DeepDiver1975
DeepDiver1975 deleted the minor_dav_cleanup branch August 12, 2016 10:02
@lock

lock Bot commented Aug 5, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock Bot locked as resolved and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants