Repository navigation
Conversation
|
@rullzer, thanks for your PR! By analyzing the annotation information on this pull request, we identified @DeepDiver1975, @LukasReschke and @PVince81 to be potential reviewers |
Member
Author
|
Aaah it seems the repo is moved... let see. |
| ); | ||
| }); | ||
|
|
||
| $container->registerService('OCA\DAV\Migration\Classification', function ($c) { |
Member
There was a problem hiding this comment.
Did we also kill the update steps
Member
There was a problem hiding this comment.
We still have them, so this should be kept
Member
There was a problem hiding this comment.
https://github.com/owncloud/core/pull/25654/files - Not sure if we want to also kill them
Member
Author
There was a problem hiding this comment.
aaah right lets think about that.
rullzer
added
2. developing
Member
Author
|
Ok lets close this and just go over it ourself when we touch the code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See: owncloud/core#25763
CC: @LukasReschke @MorrisJobke @nickvergessen @icewind1991