Skip to content

feat: optional dependent resource - #2240

Closed
csviri wants to merge 54 commits into
nextfrom
optional-dependent
Closed

feat: optional dependent resource#2240
csviri wants to merge 54 commits into
nextfrom
optional-dependent

Conversation

@csviri

@csviri csviri commented Feb 13, 2024

Copy link
Copy Markdown
Collaborator

No description provided.

@csviri csviri self-assigned this Feb 13, 2024
@csviri csviri linked an issue Feb 13, 2024 that may be closed by this pull request
Support for optional @Dependent resources #2238
Closed
@csviri
csviri force-pushed the optional-dependent branch from 8c0b66b to a308146 Compare March 6, 2024 09:50
@csviri
csviri marked this pull request as ready for review March 6, 2024 14:32
@openshift-ci
openshift-ci Bot requested review from adam-sandor and andreaTP March 6, 2024 14:32
@csviri

csviri commented Mar 6, 2024

Copy link
Copy Markdown
Collaborator Author

For customizing the expiration mechanism there will be a separate PR.

@csviri
csviri requested a review from metacosm March 6, 2024 15:05
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 8, 2024
@csviri
csviri force-pushed the optional-dependent branch from 17004b3 to cdce182 Compare March 12, 2024 09:18
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 12, 2024
metacosm
metacosm requested changes Mar 12, 2024
View reviewed changes
Comment thread ...n/java/io/javaoperatorsdk/operator/processing/dependent/workflow/DefaultManagedWorkflow.java Resolved
Comment thread ...amework-core/src/main/java/io/javaoperatorsdk/operator/processing/expiration/Expiration.java
package io.javaoperatorsdk.operator.processing.expiration;


public interface Expiration {

@metacosm metacosm Mar 12, 2024

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need an interface for this? Do we envision multiple implementations?

@csviri csviri Mar 12, 2024

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is same principle as for retry, some might be able different strategy, so created an abstraction for that.

Comment thread ...ore/src/main/java/io/javaoperatorsdk/operator/processing/expiration/ExpirationExecution.java
@@ -0,0 +1,9 @@
package io.javaoperatorsdk.operator.processing.expiration;

public interface ExpirationExecution {

@metacosm metacosm Mar 12, 2024

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment than for Expiration.

Comment thread ...io/javaoperatorsdk/operator/processing/dependent/workflow/CRDPresentActivationCondition.java
import io.javaoperatorsdk.operator.processing.retry.GenericRetry;
import io.javaoperatorsdk.operator.processing.retry.Retry;

public class CRDPresentActivationCondition implements Condition<HasMetadata, HasMetadata> {

@metacosm metacosm Mar 12, 2024

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be better implemented as a utilty class that could be reused elsewhere and shared across reconcilers, in particular because Controller also can check the availability of the CRD so it would be better if the same logic / implementation / cache could be reused/shared everywhere this functionality is needed.

@csviri csviri Mar 12, 2024

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that is true, I don't like utilities / static scoped states, usually, those lead to problems (eventually). But will think about how to handle that.

@csviri
csviri force-pushed the optional-dependent branch from cdce182 to 422224d Compare March 19, 2024 07:34
@csviri
csviri force-pushed the optional-dependent branch from 422224d to daf2262 Compare March 26, 2024 14:19
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 11, 2024
@csviri
csviri force-pushed the next branch 2 times, most recently from 88c4960 to afe3d7d Compare May 17, 2024 10:46
csviri and others added 8 commits May 21, 2024 21:02
@csviri
chore: set version to 5.0.0-SNAPSHOT (#2200)
a1235bc 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
improve: java version minimal 11, tested on 21 (#2207)
0463ce7 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
improve: remove deprecated EventFilter (#2208)
ff2bbfa 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
docs: 5.0 migration guide skeleton (#2210)
9eb3fac 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
improve: managed dependent reconciliation results not optional (#2212)
c0a741c 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
improve: remove deprecated RetryConfiguration (#2211)
76bbc6c 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
feat: JDK client is now the default (#2235)
1df8a80 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@metacosm @csviri
fix: update SCM information (#2237)
2389cda 
Signed-off-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
metacosm and others added 17 commits May 21, 2024 21:02
@metacosm @csviri
fix: remove now unneeded okhttp dependency override, wrong comment (#…
1ada74d 
…2331)

Signed-off-by: Chris Laprun <claprun@redhat.com>
Co-authored-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@metacosm @csviri
feat: run spotless on compile (#2330)
37dbf1f 
Signed-off-by: Chris Laprun <claprun@redhat.com>
Co-authored-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@metacosm @csviri
refactor: clean-up (#2325)
d3a15e4 
Signed-off-by: Chris Laprun <claprun@redhat.com>
Co-authored-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
improve: samples correctly create status object for SSA (#2365)
599dd46 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri @metacosm
improve: named event sources and related changes (#2340)
1e56113 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Co-authored-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri @metacosm
feat: silent exception handling in managed workflows (#2363)
16bb1b3 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Co-authored-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
feat: feature flag to not clone secondary resource on access (#2364)
486c750 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
fix: unit test for event processor stopping (#2373)
f036f86 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri @metacosm
feat: all event source is resource event source (#2367)
27ca97c 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Co-authored-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
feat: read-only bulk dependent (#2372)
fa2f06a 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri @metacosm
feat: remove automatic observed generation handling (#2382)
9acfda6 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Co-authored-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
docs: bulk dependent resource migration (#2383)
dc4dc90 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
fix: correct default secondary to primary mapper (#2386)
04febbd 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
improve: secondaryToPrimary check type of owner reference (#2371)
463ee73 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
improve: remove deprecated APIs (#2375)
9119c59 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
improve: ensure unique name on event sources (#2370)
78b0586 
* improve: ensure unique name on event sources

Signed-off-by: Attila Mészáros <csviri@gmail.com>

* fix

Signed-off-by: Attila Mészáros <csviri@gmail.com>

---------

Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
fix: pom formatting
cc57156 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
csviri added 4 commits May 21, 2024 23:22
@csviri
docs: migrate v5 changes to docsy (#2397)
5337e79 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
docs: @workflow usage (#2413)
4105421 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
feat: API to check if next reconciliation is imminent (#2272)
705c9b1 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
feat: optional dependent
2d22dd2
@csviri
csviri force-pushed the optional-dependent branch from 7f97e23 to 2d22dd2 Compare June 13, 2024 07:26
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 13, 2024
@csviri
fix
405d64a 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@openshift-merge-robot

openshift-merge-robot commented Jun 17, 2024

Copy link
Copy Markdown

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 17, 2024
@csviri csviri closed this Jun 19, 2024
@csviri
csviri deleted the optional-dependent branch November 8, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@metacosm metacosm metacosm requested changes
@adam-sandor adam-sandor Awaiting requested review from adam-sandor
@andreaTP andreaTP Awaiting requested review from andreaTP

Assignees

@csviri csviri

Labels

needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support for optional @Dependent resources

3 participants

@csviri @openshift-merge-robot @metacosm