Skip to content

improve: named event sources and related changes - #2340

Merged
csviri merged 28 commits into
nextfrom
es-name-config
Apr 28, 2024
Merged

improve: named event sources and related changes#2340
csviri merged 28 commits into
nextfrom
es-name-config

Conversation

@csviri

@csviri csviri commented Apr 11, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Moves name directly to EventSource and makes improvements on built in Event Source APIs

@openshift-ci
openshift-ci Bot requested review from adam-sandor and andreaTP April 11, 2024 11:57
@csviri
csviri marked this pull request as draft April 11, 2024 12:09
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 11, 2024
This was linked to issues Apr 11, 2024
Define EventSource via Configuration not via Instance #1937
Closed
DependentResource Should Provide Name of the Event Source Explicitly #2123
Closed
Improved Event Source Management For Dependent Resources #2285
Closed
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 13, 2024
csviri added 2 commits April 17, 2024 16:09
@csviri
improve: mamed event sources and equality of event sources and their …
7db2932 
…implications

Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
format
a3fc7e7 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 17, 2024
csviri added 3 commits April 17, 2024 16:12
@csviri
format
614117d 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
remove of NamedEventSource
4879c5c 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
improvements on imple, fixes, unit tests
012ad6d 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
csviri added 8 commits April 22, 2024 12:54
@csviri
informer registration logic and same scope for informer
9b3a943 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
fixes
5b0bd77 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
changes
983c258 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
fix
56ea9dc 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
wip
938cc88 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
PerResourcePolling refactor
ba3aabd 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
remove of scopeEquasl and related features
d987875 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
fix
77c6aab 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri csviri changed the title improve: named event sources and equality of event sources and their implications improve: named event sources and related changes Apr 23, 2024
@csviri

csviri commented Apr 23, 2024

Copy link
Copy Markdown
Collaborator Author

This PR does not implement the scope checking

csviri added 3 commits April 23, 2024 14:40
@csviri
improvements and refactor
6c1be14 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
fixes
0344850 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
comment
dea53d4 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
metacosm
metacosm requested changes Apr 26, 2024
View reviewed changes
Comment thread ...rk-core/src/main/java/io/javaoperatorsdk/operator/processing/event/EventSourceRetriever.java Outdated
* If an EventSource is already registered with the specified name, the registration will be
* ignored. It is the user's responsibility to handle the naming correctly, thus to not try to
* register different event source with same name that is already registered.
* When using this method is important to explicitly name the event source, since comparison is

@metacosm metacosm Apr 26, 2024

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I understand this comment. This needs to be clarified.

@csviri csviri Apr 26, 2024

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reformulated, does it makes more sense now? :)

csviri and others added 2 commits April 26, 2024 15:46
@csviri
javadoc improvements
a142b2d 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@metacosm
docs: clarify why explicit naming is important with dynamic registration
89eeeea 
Signed-off-by: Chris Laprun <claprun@redhat.com>
@csviri
csviri merged commit db61dfb into next Apr 28, 2024
@csviri
csviri deleted the es-name-config branch April 28, 2024 08:20
csviri added a commit that referenced this pull request May 17, 2024
@csviri @metacosm
improve: named event sources and related changes (#2340)
79b292a 

Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Co-authored-by: Chris Laprun <claprun@redhat.com>
csviri added a commit that referenced this pull request May 17, 2024
@csviri @metacosm
improve: named event sources and related changes (#2340)
f598732 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Co-authored-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
csviri added a commit that referenced this pull request May 21, 2024
@csviri @metacosm
improve: named event sources and related changes (#2340)
1e56113 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Co-authored-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
csviri added a commit that referenced this pull request Jun 17, 2024
@csviri @metacosm
improve: named event sources and related changes (#2340)
33095d1 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Co-authored-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
metacosm added a commit that referenced this pull request Jul 8, 2024
@csviri @metacosm
improve: named event sources and related changes (#2340)
c548ccb 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Co-authored-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
metacosm added a commit that referenced this pull request Jul 9, 2024
@csviri @metacosm
improve: named event sources and related changes (#2340)
7a3c46e 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Co-authored-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
metacosm added a commit that referenced this pull request Jul 12, 2024
@csviri @metacosm
improve: named event sources and related changes (#2340)
4cbd431 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Co-authored-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
csviri added a commit that referenced this pull request Aug 8, 2024
@csviri @metacosm
improve: named event sources and related changes (#2340)
1b5d8d0 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Co-authored-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri csviri mentioned this pull request Aug 14, 2024
Merged
csviri added a commit that referenced this pull request Aug 15, 2024
@csviri @metacosm
improve: named event sources and related changes (#2340)
8f397f8 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Co-authored-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
metacosm added a commit that referenced this pull request Aug 29, 2024
@csviri @metacosm
improve: named event sources and related changes (#2340)
3cfc1fc 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Co-authored-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri csviri mentioned this pull request Sep 17, 2024
Merged
csviri added a commit that referenced this pull request Sep 18, 2024
@csviri @metacosm
improve: named event sources and related changes (#2340)
190555c 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Co-authored-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
csviri added a commit that referenced this pull request Sep 20, 2024
@csviri @metacosm
improve: named event sources and related changes (#2340)
d67c971 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Co-authored-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
metacosm added a commit that referenced this pull request Oct 10, 2024
@csviri @metacosm
improve: named event sources and related changes (#2340)
1ba6045 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Co-authored-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
metacosm added a commit that referenced this pull request Nov 5, 2024
@csviri @metacosm
improve: named event sources and related changes (#2340)
d7d3221 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Co-authored-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
metacosm added a commit that referenced this pull request Nov 6, 2024
@csviri @metacosm
improve: named event sources and related changes (#2340)
fd04610 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Co-authored-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
csviri added a commit that referenced this pull request Nov 13, 2024
@csviri @metacosm
improve: named event sources and related changes (#2340)
2f30de3 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Co-authored-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
metacosm added a commit that referenced this pull request Nov 19, 2024
@csviri @metacosm
improve: named event sources and related changes (#2340)
1b8ac91 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Co-authored-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
metacosm added a commit that referenced this pull request Nov 20, 2024
@csviri @metacosm
improve: named event sources and related changes (#2340)
2344211 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Co-authored-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
metacosm added a commit that referenced this pull request Nov 27, 2024
@csviri @metacosm
improve: named event sources and related changes (#2340)
f08ea79 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Co-authored-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
This was referenced Dec 3, 2024
Merged
Closed
csviri added a commit that referenced this pull request Dec 6, 2024
@csviri @metacosm
improve: named event sources and related changes (#2340)
55d38c4 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Co-authored-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@metacosm metacosm metacosm approved these changes
@adam-sandor adam-sandor Awaiting requested review from adam-sandor
@andreaTP andreaTP Awaiting requested review from andreaTP

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

3 participants

@csviri @metacosm @openshift-merge-robot