[joelanford]

Summary

• Enable TLSAdherence in the default and OKD feature sets to match 5.1 branch
• Regenerate the config/v1 CRD and feature-gate payload manifests.

Test plan

• make update-codegen-crds API_GROUP_VERSIONS=config.openshift.io/v1

Generated with the assistance of generative AI

[openshift-ci-robot]

@joelanford: This pull request references Jira Issue OCPBUGS-129428, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
• release note text is set and does not match the template
• dependent bug Jira Issue OCPBUGS-129427 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-129427 targets the "5.1.0" version, which is one of the valid target versions: 5.1.0
• bug has dependents

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

• Enable TLSAdherence in the default and OKD feature sets to match 5.1 branch
• Regenerate the config/v1 CRD and feature-gate payload manifests.

Test plan

• make update-codegen-crds API_GROUP_VERSIONS=config.openshift.io/v1

Generated with the assistance of generative AI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

• Configuration used: Repository YAML (base), Central YAML (inherited)
• Review profile: CHILL
• Plan: Enterprise
• Run ID: 3575ab4b-9d4c-4f2a-93ee-9aa122caed0e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

Hello @joelanford! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[openshift-merge-bot]

Pipeline controller notification

This PR uses the pipeline controller for second-stage tests. Selection and triggering follow the repository configuration.

Use /test ? to list jobs, /pipeline remaining to request missing second-stage tests, or /pipeline required to rerun the selected second-stage set.

[wking]

Will need the same coverage-policy waivers we granted dev/5.1, but otherwise:

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wking
Once this PR has been reviewed and has the lgtm label, please assign everettraven for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-merge-bot]

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-azure
/test e2e-gcp
/test e2e-upgrade
/test e2e-upgrade-out-of-change

[wking]

I don't understand how minor-images CI is giving us:

...
Auto-merging payload-manifests/featuregates/featureGate-5-10-SelfManagedHA-Default.yaml
CONFLICT (add/add): Merge conflict in payload-manifests/featuregates/featureGate-5-10-SelfManagedHA-Default.yaml
...
Automatic merge failed; fix conflicts and then commit the result.
# Error: exit status 1

Do we need to run some re-gen command? Or...?

[JoelSpeed]

Oddly here we do have a failure in one of the tests, any idea?

[JoelSpeed]

/test verify-hypershift-integration
/test minor-images

[JoelSpeed]

/hold

This is targetting 5.0.z, adding the hold so we don't forget and merge prior

[JoelSpeed]

/retest

[joelanford]

Not sure about minor-images and verify-hypershift-integration. I accidentally opened #3084 against master, tried to change it's base to release-5.0, but it seemed like that confused prow. So I closed and opened anew. But it seems like prow is maybe still seeing the jobs based on the commit IDs.

I'm wondering if minor-images and verify-hypershift-integration are stale from the master PR and not configured in the release-5.0 branch.

[openshift-ci]

@joelanford: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/verify-feature-promotion	e50c203	link	true	/test verify-feature-promotion
ci/prow/e2e-gcp	e50c203	link	true	/test e2e-gcp

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.