Skip to content

OCPBUGS-129428: Enable TLSAdherence by default - #3084

Closed
joelanford wants to merge 1 commit into
openshift:release-5.0from
joelanford:tls-adherence-default
Closed

joelanford wants to merge 1 commit into
openshift:release-5.0from
joelanford:tls-adherence-default

Conversation

@joelanford

@joelanford joelanford commented Oct 7, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Enable TLSAdherence in the default and OKD feature sets to match 5.1 branch
  • Regenerate the config/v1 CRD and feature-gate payload manifests.

Test plan

  • make update-codegen-crds API_GROUP_VERSIONS=config.openshift.io/v1

Generated with the assistance of generative AI

Co-Authored-By: GPT-6 Luna <noreply@openai.com>
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification

This PR uses the pipeline controller for second-stage tests. Selection and triggering follow the repository configuration.

Use /test ? to list jobs, /pipeline remaining to request missing second-stage tests, or /pipeline required to rerun the selected second-stage set.

@openshift-ci

openshift-ci Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

Hello @joelanford! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@coderabbitai

coderabbitai Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository YAML (base), Central YAML (inherited)
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: 1af321dc-a813-4c43-b751-382dd0d12b2b
📥 Commits

Reviewing files that changed from the base of the PR and between ef6066a and e50c203.

⛔ Files ignored due to path filters (21)
  • config/v1/zz_generated.crd-manifests/0000_10_config-operator_01_apiservers-Default.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
  • config/v1/zz_generated.crd-manifests/0000_10_config-operator_01_apiservers-OKD.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
  • config/v1/zz_generated.crd-manifests/0000_10_config-operator_01_infrastructures-Default.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
  • config/v1/zz_generated.crd-manifests/0000_10_config-operator_01_infrastructures-OKD.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
  • machineconfiguration/v1/zz_generated.crd-manifests/0000_80_machine-config_01_controllerconfigs-Default.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
  • machineconfiguration/v1/zz_generated.crd-manifests/0000_80_machine-config_01_controllerconfigs-OKD.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
  • machineconfiguration/v1/zz_generated.crd-manifests/0000_80_machine-config_01_machineconfigpools-Hypershift-CustomNoUpgrade.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
  • machineconfiguration/v1/zz_generated.crd-manifests/0000_80_machine-config_01_machineconfigpools-Hypershift-Default.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
  • machineconfiguration/v1/zz_generated.crd-manifests/0000_80_machine-config_01_machineconfigpools-Hypershift-DevPreviewNoUpgrade.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
  • machineconfiguration/v1/zz_generated.crd-manifests/0000_80_machine-config_01_machineconfigpools-Hypershift-OKD.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
  • machineconfiguration/v1/zz_generated.crd-manifests/0000_80_machine-config_01_machineconfigpools-Hypershift-TechPreviewNoUpgrade.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
  • machineconfiguration/v1/zz_generated.crd-manifests/0000_80_machine-config_01_machineconfigpools.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
  • machineconfiguration/v1/zz_generated.crd-manifests/0000_80_machine-config_01_osimagestreams-Hypershift.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
  • machineconfiguration/v1/zz_generated.crd-manifests/0000_80_machine-config_01_osimagestreams.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
  • machineconfiguration/v1alpha1/zz_generated.crd-manifests/0000_80_machine-config_01_osimagestreams-Hypershift.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
  • machineconfiguration/v1alpha1/zz_generated.crd-manifests/0000_80_machine-config_01_osimagestreams.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
  • operator/v1/zz_generated.crd-manifests/0000_12_etcd_01_etcds-Default.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
  • operator/v1/zz_generated.crd-manifests/0000_12_etcd_01_etcds-DevPreviewNoUpgrade.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
  • operator/v1/zz_generated.crd-manifests/0000_12_etcd_01_etcds-OKD.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
  • operator/v1/zz_generated.crd-manifests/0000_12_etcd_01_etcds-TechPreviewNoUpgrade.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
  • operator/v1/zz_generated.crd-manifests/0000_12_etcd_01_etcds.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
📒 Files selected for processing (40)
  • .golangci.yaml
  • features.md
  • features/features.go
  • operator/v1/tests/etcds.operator.openshift.io/AAA_ungated.yaml
  • operator/v1/tests/etcds.operator.openshift.io/HardwareSpeed.yaml
  • payload-command/empty-resources/0000_10_config-operator_02_criocredentialproviderconfig.cr.yaml
  • payload-command/ordering/ordering_test.go
  • payload-manifests/crds/0000_10_config-operator_01_apiservers-Default.crd.yaml
  • payload-manifests/crds/0000_10_config-operator_01_apiservers-OKD.crd.yaml
  • payload-manifests/crds/0000_10_config-operator_01_infrastructures-Default.crd.yaml
  • payload-manifests/crds/0000_10_config-operator_01_infrastructures-OKD.crd.yaml
  • payload-manifests/crds/0000_12_etcd_01_etcds-Default.crd.yaml
  • payload-manifests/crds/0000_12_etcd_01_etcds-DevPreviewNoUpgrade.crd.yaml
  • payload-manifests/crds/0000_12_etcd_01_etcds-OKD.crd.yaml
  • payload-manifests/crds/0000_12_etcd_01_etcds-TechPreviewNoUpgrade.crd.yaml
  • payload-manifests/crds/0000_12_etcd_01_etcds.crd.yaml
  • payload-manifests/crds/0000_80_machine-config_01_controllerconfigs-Default.crd.yaml
  • payload-manifests/crds/0000_80_machine-config_01_controllerconfigs-OKD.crd.yaml
  • payload-manifests/crds/0000_80_machine-config_01_machineconfigpools-Hypershift-CustomNoUpgrade.crd.yaml
  • payload-manifests/crds/0000_80_machine-config_01_machineconfigpools-Hypershift-Default.crd.yaml
  • payload-manifests/crds/0000_80_machine-config_01_machineconfigpools-Hypershift-DevPreviewNoUpgrade.crd.yaml
  • payload-manifests/crds/0000_80_machine-config_01_machineconfigpools-Hypershift-OKD.crd.yaml
  • payload-manifests/crds/0000_80_machine-config_01_machineconfigpools-Hypershift-TechPreviewNoUpgrade.crd.yaml
  • payload-manifests/crds/0000_80_machine-config_01_machineconfigpools.crd.yaml
  • payload-manifests/crds/0000_80_machine-config_01_osimagestreams-Hypershift.crd.yaml
  • payload-manifests/crds/0000_80_machine-config_01_osimagestreams.crd.yaml
  • payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml
  • payload-manifests/featuregates/featureGate-4-10-Hypershift-DevPreviewNoUpgrade.yaml
  • payload-manifests/featuregates/featureGate-4-10-Hypershift-OKD.yaml
  • payload-manifests/featuregates/featureGate-4-10-Hypershift-TechPreviewNoUpgrade.yaml
  • payload-manifests/featuregates/featureGate-4-SelfManagedHA-Default.yaml
  • payload-manifests/featuregates/featureGate-4-SelfManagedHA-DevPreviewNoUpgrade.yaml
  • payload-manifests/featuregates/featureGate-4-SelfManagedHA-OKD.yaml
  • payload-manifests/featuregates/featureGate-4-SelfManagedHA-TechPreviewNoUpgrade.yaml
  • payload-manifests/featuregates/featureGate-5-10-SelfManagedHA-Default.yaml
  • payload-manifests/featuregates/featureGate-5-10-SelfManagedHA-DevPreviewNoUpgrade.yaml
  • payload-manifests/featuregates/featureGate-5-10-SelfManagedHA-OKD.yaml
  • payload-manifests/featuregates/featureGate-5-10-SelfManagedHA-TechPreviewNoUpgrade.yaml
  • tools/codegen/cmd/featuregate-test-analyzer.go
  • tools/codegen/pkg/sippy/json_types.go
💤 Files with no reviewable changes (11)
  • payload-manifests/crds/0000_12_etcd_01_etcds-Default.crd.yaml
  • payload-manifests/crds/0000_12_etcd_01_etcds.crd.yaml
  • payload-manifests/crds/0000_80_machine-config_01_machineconfigpools-Hypershift-TechPreviewNoUpgrade.crd.yaml
  • payload-manifests/crds/0000_80_machine-config_01_machineconfigpools-Hypershift-CustomNoUpgrade.crd.yaml
  • payload-manifests/crds/0000_80_machine-config_01_machineconfigpools-Hypershift-OKD.crd.yaml
  • payload-manifests/crds/0000_80_machine-config_01_machineconfigpools-Hypershift-DevPreviewNoUpgrade.crd.yaml
  • payload-manifests/crds/0000_12_etcd_01_etcds-TechPreviewNoUpgrade.crd.yaml
  • payload-manifests/crds/0000_12_etcd_01_etcds-OKD.crd.yaml
  • payload-manifests/crds/0000_12_etcd_01_etcds-DevPreviewNoUpgrade.crd.yaml
  • payload-manifests/crds/0000_80_machine-config_01_machineconfigpools-Hypershift-Default.crd.yaml
  • payload-manifests/crds/0000_80_machine-config_01_osimagestreams-Hypershift.crd.yaml

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.


📝 Walkthrough

Walkthrough

The pull request updates feature-gate definitions and release manifests, adds APIServer and GCP platform-status fields to CRD schemas, and removes several CRD manifests. It adds a test for ordering empty-resource custom resources after matching CRDs. The feature-gate test analyzer accepts date-only development dates, and the Sippy timestamp filter uses UTC RFC3339 formatting.

Priority: ➖ Normal

Merge Risk: ⚪ Minimal · up to e50c2

The versioned feature-gate manifests select the appropriate release range. No actionable merge-blocking issue remains after normal checks.

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 44.44% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 9 functions across 4 files. (24 skipped: … Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (14 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The only changed test file adds a standard Go test named TestEmptyResourceCRDOrdering. It does not use Ginkgo It, Describe, Context, or When titles. The test name is static and descriptive; …
Test Structure And Quality ✅ Passed PASS: The only added Go test is payload-command/ordering/ordering_test.go, which uses the standard testing package (TestEmptyResourceCRDOrdering), not Ginkgo. It reads repository YAML files only…
Microshift Test Compatibility ✅ Passed The pull request adds one test, TestEmptyResourceCRDOrdering, using the standard Go testing package. The diff adds no Ginkgo It, Describe, Context, or When e2e tests. The MicroShift Ginkgo…
Single Node Openshift (Sno) Test Compatibility ✅ Passed PASS: The pull request adds one Go test, TestEmptyResourceCRDOrdering, using the standard testing package. The diff adds no Ginkgo constructs such as It, Describe, Context, or When, and it…
Topology-Aware Scheduling Compatibility ✅ Passed The PR does not add or modify workload deployment manifests, operator controllers, or scheduling logic. The changed manifests are CRDs, FeatureGate resources, an empty custom resource, and generated p…
Ote Binary Stdout Contract ✅ Passed The pull request adds no OTE binary process-level stdout write. The only new Go code is feature-gate initialization, manifest-ordering test code, date parsing, and timestamp formatting. The changed an…
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PASS — The PR adds one Go test, TestEmptyResourceCRDOrdering, using testing.T, not Ginkgo. It only reads local YAML files under the repository and performs filename/run-level comparisons. No new G…
No-Weak-Crypto ✅ Passed The pull request does not introduce weak cryptography. The changed code enables the existing TLSAdherence feature gate and updates generated CRD and feature-gate manifests. The added Go code contains …
Container-Privileges ✅ Passed The pull request does not add privileged container settings. The diff adds or updates FeatureGate and CRD manifests, including TLSAdherence, and contains no privileged: true, hostPID, hostNetwork, h…
No-Sensitive-Data-In-Logs ✅ Passed No changed code adds logging of passwords, tokens, API keys, PII, session IDs, internal hostnames, or customer data. The new test reports repository manifest names and paths only. The date parser retu…
Title check ✅ Passed The title clearly identifies the main change: enabling TLSAdherence by default. This matches the pull request objectives.
Description check ✅ Passed The description directly covers enabling TLSAdherence in the default and OKD feature sets and regenerating the related manifests.
Full details: Docstring Coverage

Explanation

Docstring coverage is 44.44% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 9 functions across 4 files. (24 skipped: 24 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 2
⚔️ Resolve merge conflicts 💡
  • Resolve merge conflict in branch tls-adherence-default
🧪 Generate unit tests (beta)
  • Create a new PR
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 7, 2026
@openshift-ci

openshift-ci Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

1 similar comment
@openshift-ci

openshift-ci Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci Bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 7, 2026
@joelanford
joelanford changed the base branch from master to release-5.0 October 7, 2026 17:01
@openshift-ci openshift-ci Bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 7, 2026
@joelanford

Copy link
Copy Markdown
Member Author

/hold

Waiting until after 5.0 is released to merge this.

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 7, 2026
@redhat-chai-bot

Copy link
Copy Markdown
Contributor

/jira refresh

@openshift-ci-robot

Copy link
Copy Markdown

@redhat-chai-bot: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@joelanford joelanford removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 7, 2026
@joelanford joelanford changed the title Enable TLSAdherence by default OCPBUGS-129428: Enable TLSAdherence by default Oct 7, 2026
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 7, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@joelanford: This pull request references Jira Issue OCPBUGS-129428, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

  • Enable TLSAdherence in the default and OKD feature sets to match 5.1 branch
  • Regenerate the config/v1 CRD and feature-gate payload manifests.

Test plan

  • make update-codegen-crds API_GROUP_VERSIONS=config.openshift.io/v1

Generated with the assistance of generative AI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@joelanford

Copy link
Copy Markdown
Member Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 7, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@joelanford: This pull request references Jira Issue OCPBUGS-129428, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.0.0) matches configured target version for branch (5.0.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-129427 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-129427 targets the "5.1.0" version, which is one of the valid target versions: 5.1.0
  • bug has dependents
Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@joelanford

Copy link
Copy Markdown
Member Author

/test minor-images
/test verify-hypershift-integration

@openshift-ci

openshift-ci Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

@joelanford: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test build
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-azure
/test e2e-gcp
/test e2e-upgrade
/test e2e-upgrade-out-of-change
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-techpreview
/test images
/test integration
/test lint
/test okd-scos-images
/test unit
/test verify
/test verify-client-go
/test verify-crd-schema
/test verify-crdify
/test verify-deps
/test verify-feature-promotion

The following commands are available to trigger optional jobs:

/test api-review

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-api-release-5.0-build
pull-ci-openshift-api-release-5.0-images
pull-ci-openshift-api-release-5.0-integration
pull-ci-openshift-api-release-5.0-lint
pull-ci-openshift-api-release-5.0-okd-scos-images
pull-ci-openshift-api-release-5.0-unit
pull-ci-openshift-api-release-5.0-verify
pull-ci-openshift-api-release-5.0-verify-client-go
pull-ci-openshift-api-release-5.0-verify-crd-schema
pull-ci-openshift-api-release-5.0-verify-crdify
pull-ci-openshift-api-release-5.0-verify-deps
pull-ci-openshift-api-release-5.0-verify-feature-promotion
Details

In response to this:

/test minor-images
/test verify-hypershift-integration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@joelanford joelanford closed this Oct 7, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@joelanford: This pull request references Jira Issue OCPBUGS-129428. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

Details

In response to this:

Summary

  • Enable TLSAdherence in the default and OKD feature sets to match 5.1 branch
  • Regenerate the config/v1 CRD and feature-gate payload manifests.

Test plan

  • make update-codegen-crds API_GROUP_VERSIONS=config.openshift.io/v1

Generated with the assistance of generative AI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

@joelanford: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify-crdify e50c203 link true /test verify-crdify
ci/prow/lint e50c203 link true /test lint
ci/prow/verify-crd-schema e50c203 link true /test verify-crd-schema
ci/prow/verify-client-go e50c203 link true /test verify-client-go
ci/prow/images e50c203 link true /test images
ci/prow/build e50c203 link true /test build
ci/prow/minor-images e50c203 link true /test minor-images
ci/prow/verify-feature-promotion e50c203 link true /test verify-feature-promotion
ci/prow/verify-hypershift-integration e50c203 link false /test verify-hypershift-integration
ci/prow/integration e50c203 link true /test integration
ci/prow/verify e50c203 link true /test verify
ci/prow/verify-feature-promotion e50c203 link true /test verify-feature-promotion
ci/prow/okd-scos-images e50c203 link true /test okd-scos-images
ci/prow/verify-deps e50c203 link true /test verify-deps
ci/prow/unit e50c203 link true /test unit

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants