Repository navigation
OCPBUGS-129428: Enable TLSAdherence by default - #3084
joelanford wants to merge 1 commit into
Conversation
Co-Authored-By: GPT-6 Luna <noreply@openai.com>
|
Pipeline controller notification This PR uses the pipeline controller for second-stage tests. Selection and triggering follow the repository configuration. Use |
|
Hello @joelanford! Some important instructions when contributing to openshift/api: |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
⛔ Files ignored due to path filters (21)
📒 Files selected for processing (40)
💤 Files with no reviewable changes (11)
Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review. 📝 WalkthroughWalkthroughThe pull request updates feature-gate definitions and release manifests, adds APIServer and GCP platform-status fields to CRD schemas, and removes several CRD manifests. It adds a test for ordering empty-resource custom resources after matching CRDs. The feature-gate test analyzer accepts date-only development dates, and the Sippy timestamp filter uses UTC RFC3339 formatting. Priority: ➖ Normal Merge Risk: ⚪ Minimal · up to The versioned feature-gate manifests select the appropriate release range. No actionable merge-blocking issue remains after normal checks. 🚥 Pre-merge checks | ✅ 14 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (14 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 44.44% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 9 functions across 4 files. (24 skipped: 24 unsupported.)
✨ Finishing Touches 💡 2⚔️ Resolve merge conflicts 💡
🧪 Generate unit tests (beta)
🛠️ Fix failing CI checks 💡
Comment |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
1 similar comment
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/hold Waiting until after 5.0 is released to merge this. |
|
/jira refresh |
|
@redhat-chai-bot: No Jira issue is referenced in the title of this pull request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@joelanford: This pull request references Jira Issue OCPBUGS-129428, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@joelanford: This pull request references Jira Issue OCPBUGS-129428, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test minor-images |
|
@joelanford: The specified target(s) for The following commands are available to trigger optional jobs: Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@joelanford: This pull request references Jira Issue OCPBUGS-129428. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@joelanford: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Summary
Test plan
make update-codegen-crds API_GROUP_VERSIONS=config.openshift.io/v1Generated with the assistance of generative AI