Skip to content

meta: add Github Reviews on new PR - #53894

Closed
avivkeller wants to merge 1 commit into
nodejs:mainfrom
avivkeller:request-reviews
Closed

avivkeller wants to merge 1 commit into
nodejs:mainfrom
avivkeller:request-reviews

Conversation

@avivkeller

Copy link
Copy Markdown
Member

Ref: nodejs/admin#895

This PR has Github Actions request a review from team members of relavent teams from CODEOWNERS.

For example, this change would add the following users as requested reviewers:

Set(4) { 'bnb', 'targos', 'richardlau', 'marco-ippolito' }

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. labels Jul 17, 2024
@targos

targos commented Jul 17, 2024

Copy link
Copy Markdown
Member

I'm not sure about this. I remember that in the past some collaborators explicitly asked that we don't use the request for review feature because it conflicted with their professional GitHub workflows.

@avivkeller

avivkeller commented Jul 17, 2024 •

Copy link
Copy Markdown
Member Author

because it conflicted with their professional GitHub workflows.

Could you elaborate?

(Personally, I'd prefer if the teams were review-requested, but that's currently not possible)

@targos

targos commented Jul 17, 2024

Copy link
Copy Markdown
Member

I don't remember exactly, but I think it was about the https://github.com/pulls/review-requested page.

@avivkeller

avivkeller commented Jul 17, 2024 •

Copy link
Copy Markdown
Member Author

I'm okay if the comment / requesting reviews is removed entirely. Frankly, It doesn't cover a large portion of source files and people might not want to be subscribed to issues.

Various members are monitoring the issue tracker, so if a ping is needed, it can always be done manually, so what if the whole thing was just removed?

WDYT @targos (CC @Trott who also mentioned doing this)

@avivkeller

Copy link
Copy Markdown
Member Author

I've reopened this as an issue to gain more of a discussion around it, rather than a change.

@avivkeller avivkeller closed this Jul 17, 2024
@avivkeller

Copy link
Copy Markdown
Member Author

Sorry for the noise, I've moved this to #53897

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants