Repository navigation
meta: add Github Reviews on new PR - #53894
avivkeller wants to merge 1 commit into
Conversation
|
Review requested:
|
|
I'm not sure about this. I remember that in the past some collaborators explicitly asked that we don't use the request for review feature because it conflicted with their professional GitHub workflows. |
Could you elaborate? (Personally, I'd prefer if the teams were review-requested, but that's currently not possible) |
|
I don't remember exactly, but I think it was about the https://github.com/pulls/review-requested page. |
|
I'm okay if the comment / requesting reviews is removed entirely. Frankly, It doesn't cover a large portion of source files and people might not want to be subscribed to issues. Various members are monitoring the issue tracker, so if a ping is needed, it can always be done manually, so what if the whole thing was just removed? |
|
I've reopened this as an issue to gain more of a discussion around it, rather than a change. |
|
Sorry for the noise, I've moved this to #53897 |
Ref: nodejs/admin#895
This PR has Github Actions request a review from team members of relavent teams from CODEOWNERS.
For example, this change would add the following users as requested reviewers: