Skip to content

Review Requesting Comment #53897

Closed as not planned
Closed as not planned

Description

@avivkeller

The triage team (including myself) constantly monitor this issue tracker, alongside other collaborators. Given this frequent monitoring, is the @nodejs-github-bot's automated comment request for teams to review issues really necessary?

The bot doesn't cover all source files, and subscribes all team members to all future updates for an issue. If specific individuals need to be notified about an issue, I believe this should be done manually. Since manual @ pings are already used for many source files, I don't think the bot comment is needed anymore.

There's no way to programatically tell who wants to be subscribed to what.

WDYT?

(Sorry for the noise regarding this in the other locations)

Activity

  1. added
    discussIssues opened for discussion and feedback.
    metaIssues and PRs related to the general management of the project.
    on Jul 17, 2024
  2. mhdawson commented on Jul 18, 2024

    @mhdawson
    Member

    Is there some problem that you are looking to solve with this? I don't think I've heard anybody complain about the bot comment requests.

  3. avivkeller commented on Jul 18, 2024

    @avivkeller
    MemberAuthor

    I was initially trying to move it to Github Actions, but there was discussion in nodejs/admin#895 and #53894 about removing it entirely, so I figured I'd open an issue

  4. ovflowd commented on Jul 19, 2024

    @ovflowd
    Member

    Again, is there any particular issue this solves? Or is this just a different approach of what we already do today?

  5. avivkeller commented on Jul 19, 2024

    @avivkeller
    MemberAuthor

    I suppose you are correct, if it ain't broke don't fix it. I'll focus my attention of issues that more aftionsble.

  6. ovflowd commented on Jul 19, 2024

    @ovflowd
    Member

    I also believe the current team organization is messy, but any overhaul is tricky and complicated.

    But just changing how we do mentions won't fix the root issue, IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    discussIssues opened for discussion and feedback.metaIssues and PRs related to the general management of the project.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions