Repository navigation
Conversation
nodejs-github-bot
added
doc
`readable._construct()` and `writable._construct()` were added to Node.js v15.0.0 via fb8cc72. Fixes: nodejs#36058
lpinca
force-pushed
the
fix/added-version-for-construct
branch
from
November 10, 2020 14:52
9da8acf to
fa94436
Compare
lpinca
changed the title
added: info for stream._construct()added: info for stream._construct()
aduh95
approved these changes
Nov 10, 2020
Contributor
|
fast-track? |
aduh95
added
the
fast-track
ronag
approved these changes
Nov 10, 2020
benjamingr
approved these changes
Nov 10, 2020
aduh95
added
the
commit-queue
github-actions
Bot
removed
the
commit-queue
Contributor
|
Landed in 60a97c0...0dee498 |
Member
|
If the methods do not exist in v14.x, the doc is wrong on that branch: https://github.com/nodejs/node/blob/v14.x/doc/api/stream.md#readable_constructcallback |
Pranay180420
pushed a commit
to Pranay180420/Node.jsforme
that referenced
this pull request
Feb 17, 2025
`readable._construct()` and `writable._construct()` were added to Node.js v15.0.0 via fb8cc72. Fixes: nodejs/node#36058 PR-URL: nodejs/node#36067 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
readable._construct()andwritable._construct()were added toNode.js v15.0.0 via fb8cc72.
Fixes: #36058
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes