Skip to content

Streams: readable stream does not get _construct called #36058

Closed
Closed
Streams: readable stream does not get _construct called#36058
Labels
streamIssues and PRs related to Node.js streams.

Description

@a0viedo
a0viedo
opened on Nov 9, 2020
  • Version: v14.15.0
  • Platform: Linux
  • Subsystem: streams

What steps will reproduce the bug?

const { Readable } = require('stream');
class ReadStream extends Readable {
  constructor() {
    super();
  }
  _construct(cb) {
      console.log('_construct called');
      cb();
  }
  _read(n) {
  }
}

(new ReadStream()).on('data', ()=>{});

If I run the above with v14.15.0 nothing gets printed but on v15.0.1 I get "_construct called".

How often does it reproduce?

Always

What is the expected behavior?

_construct should be called

What do you see instead?

_construct is not called

Additional information

According to the docs this was added on v14.13.1
image

Activity

  1. PoojaDurgad
    added
    streamIssues and PRs related to Node.js streams.
    on Nov 10, 2020

  2. lpinca commented on Nov 10, 2020

    @lpinca
    lpinca
    on Nov 10, 2020
    Member

    The feature is not available on Node.js 14.x. I think the Added in: 14.13.1 info is incorrect.

  3. nodejs-github-bot
    closed this as completedin 0dee498on Nov 10, 2020
  4. targos
    reopened this on Nov 14, 2020

  5. targos commented on Nov 14, 2020

    @targos
    targos
    on Nov 14, 2020
    Member

    If the feature is not available on v14.x, this is still an issue because the documentation has it on that branch:
    https://github.com/nodejs/node/blob/v14.x/doc/api/stream.md#readable_constructcallback
    https://github.com/nodejs/node/blob/v14.x/doc/api/stream.md#writable_constructcallback

  6. lpinca commented on Nov 14, 2020

    @lpinca
    lpinca
    on Nov 14, 2020 via email
    Member

  7. targos commented on Nov 14, 2020

    @targos
    targos
    on Nov 14, 2020
    Member

    That PR just changes the version number. I think we should entirely remove that feature from the documentation in v14

  8. lpinca commented on Nov 14, 2020

    @lpinca
    lpinca
    on Nov 14, 2020
    Member

    Ah yes you are right, it makes sense.

  9. BethGriggs
    added a commit that references this issue on Dec 2, 2020

    doc: remove documentation for stream._construct()

    f723335
  10. santigimeno
    closed this as completedon Dec 18, 2020
  11. Pranay180420
    added a commit that references this issue on Feb 17, 2025

    doc: fix `added:` info for `stream._construct()`

    b477447
  12. MayaLekova
    added a commit that references this issue on May 22, 2026

    doc: fix `added:` info for `stream._construct()`

    0dee498
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    streamIssues and PRs related to Node.js streams.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions