Repository navigation
benchmark: remove misc/v8-bench.js - #16126
Closed
joyeecheung wants to merge 1 commit into
Closed
joyeecheung wants to merge 1 commit into
joyeecheung wants to merge 1 commit into
Conversation
nodejs-github-bot
added
the
benchmark
These v8 benchmarks are oudated and have been replaced by Octane in the upstream. The benchmarking working group has already been benchmarking Octane, so this file can be removed now.
joyeecheung
force-pushed
the
remove-v8-bench
branch
from
October 10, 2017 16:15
b8a0d28 to
42a4414
Compare
Member
Author
bnoordhuis
approved these changes
Oct 10, 2017
targos
approved these changes
Oct 10, 2017
BridgeAR
approved these changes
Oct 10, 2017
cjihrig
approved these changes
Oct 10, 2017
Trott
approved these changes
Oct 11, 2017
Trott
left a comment
Trott
left a comment
Member
There was a problem hiding this comment.
LGTM. IMO no need to wait 48 hours on this. If we need to restore it (which seems unlikely), it's trivial to add the file back.
Member
Author
|
Landed in 5dbd32c, thanks! |
joyeecheung
added a commit
that referenced
this pull request
Oct 11, 2017
These v8 benchmarks are oudated and have been replaced by Octane in the upstream. The benchmarking working group has already been benchmarking Octane, so this file can be removed now. PR-URL: #16126 Ref: #16119 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Oct 12, 2017
These v8 benchmarks are oudated and have been replaced by Octane in the upstream. The benchmarking working group has already been benchmarking Octane, so this file can be removed now. PR-URL: nodejs/node#16126 Ref: nodejs/node#16119 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this pull request
Oct 18, 2017
These v8 benchmarks are oudated and have been replaced by Octane in the upstream. The benchmarking working group has already been benchmarking Octane, so this file can be removed now. PR-URL: #16126 Ref: #16119 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These v8 benchmarks are oudated and have been replaced by
Octane in the upstream. The benchmarking working group
has already been benchmarking Octane, so this file
can be removed now.
Refs: #16119
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
benchmark