You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
What's the deal with benchmark/misc/v8-bench.js? #16119
What's the deal with benchmark/misc/v8-bench.js? It does not behave like our other benchmark files. Should it live somewhere else? Should it be deleted?
Compare the scores of the V8 in Node.js and the V8 in your browser.
I tried to run these V8 benchmarks a few times and the results are pretty flaky. Also the way it's written, it doesn't work with our benchmark suites(run.js, etc.). There seems to be a merit in keeping it though.
Activity
joyeecheung commentedon Oct 10, 2017
I think this is supposed to be used like this:
./node benchmark/misc/v8-bench.jsdeps/v8/benchmarks/run.htmlI tried to run these V8 benchmarks a few times and the results are pretty flaky. Also the way it's written, it doesn't work with our benchmark suites(
run.js, etc.). There seems to be a merit in keeping it though.hashseed commentedon Oct 10, 2017
V8 bench is very outdated and has been replaced by Octane years ago.
What is the goal of this benchmark? To ensure that Node.js is on par with Chrome?
bnoordhuis commentedon Oct 10, 2017
Yes, it was added as a quick gauge.
It can be removed, IMO. We started benchmarking Octane in nodejs/benchmarking#79.
benchmark: remove misc/v8-bench.js
benchmark: remove misc/v8-bench.js
joyeecheung commentedon Oct 12, 2017
It's been removed in #16126, so closing
benchmark: remove misc/v8-bench.js