Skip to content

Version Management #274

Description

@NickNaso

Hi everyone, I want add version management functions that are available on the N-API:

It's my intention add these two functions on Napi namespace as I did for AdjustExternalMemory see: #260

Are you agree or have some suggestions to help me?

Activity

  1. mhdawson commented on May 23, 2018

    @mhdawson
    Member

    Makes sense to me. Not sure if creating a 'Util' object or something specific like 'Version' would be best. For these I'm leaning towards 'Util'

  2. devsnek commented on May 23, 2018

    @devsnek
    Member

    shouldn't you use NODE_VERSION and NAPI_VERSION instead?

  3. NickNaso commented on May 23, 2018

    @NickNaso
    MemberAuthor

    Hi @devsnek you're right it's too simple use NODE_VERSION and NAPI_VERSION, to access to these constant a developer needs only to import node.h. My thinking is to avoid as much as possible to import anything other than napi.h.

  4. mhdawson commented on May 25, 2018

    @mhdawson
    Member

    I agree that we want to avoid the need to import node.h as that makes it easy to take a dependency without palnning to.

  5. NickNaso commented on May 25, 2018

    @NickNaso
    MemberAuthor

    Ok in the next days I will try to add this feature.

  6. self-assigned this
    on Aug 29, 2018
  7. NickNaso commented on Sep 19, 2018

    @NickNaso
    MemberAuthor

    I'm closing the issue because it's solved with #325.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions