Repository navigation
Memory Management #260
Description
Hi everyone,
in my recent porting I had the need of using napi_adjust_external_memory See: https://nodejs.org/dist/latest/docs/api/n-api.html#n_api_memory_management . What do you think if we add this function to node-addon-api? if you are agree I want try to add the function with some guide.
Activity
mhdawson commentedon May 3, 2018
Agreed. Everything in the C n_api should be usable through node-addon-api, we just have not gotten them all in. Would be great if you add it in.
NickNaso commentedon May 10, 2018
@mhdawson @gabrielschulhof I'm starting on this. I want add a function on Napi namespace as reported below:
This is the same approach that I found on NAN.
I don't know if could be useful create a class called for example MemoryManagement and attach to it a method AdjustExternalMemory.
What is your thinking about that?
mhdawson commentedon May 14, 2018
It is an interesting question as we don't have any other Utility classes, and adding the method to any of the existing classes does not make sense to me.
At this point your suggestion seems like the best idea to me.
NickNaso commentedon May 14, 2018
@mhdawson Thanks for your opinion later I will provide to add it with corresponding tests and documentation.
Add memory management feature
NickNaso commentedon Jul 6, 2018
I close the issue because the PR with the feature was landed.
Add memory management feature
Add memory management feature
Add memory management feature
Add memory management feature