Repository navigation
Add IPv6 to “localhost” regex (#440) - #4862
Merged
nickvergessen merged 1 commit intoMay 15, 2017
Merged
Conversation
Signed-off-by: Oliver Hanraths <olli@coderkun.de>
|
@coderkun, thanks for your PR! By analyzing the history of the files in this pull request, we identified @LukasReschke, @tanghus and @nickvergessen to be potential reviewers. |
Codecov Report
@@ Coverage Diff @@
## master #4862 +/- ##
============================================
+ Coverage 54.18% 54.18% +<.01%
Complexity 22155 22155
============================================
Files 1363 1363
Lines 84842 84842
Branches 1322 1322
============================================
+ Hits 45969 45971 +2
+ Misses 38873 38871 -2
|
MorrisJobke
requested review from
LukasReschke,
icewind1991,
nickvergessen and
rullzer
May 14, 2017 23:19
ChristophWurst
approved these changes
May 15, 2017
ChristophWurst
left a comment
ChristophWurst
left a comment
Member
There was a problem hiding this comment.
Makes sense! Thanks a lot!
nickvergessen
approved these changes
May 15, 2017
Member
|
Only usage is "can set trusted domain" and it is necessary there, so good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the IPv6 (::1) to the regex for “localhost”
Fix #440