Skip to content

OC\AppFramework\Http\Request::REGEX_LOCALHOST does not match IPv6 localhost #440

Closed

Description

@ChristophWurst

Found in #436 (comment), not sure if this is really an issue, I didn't test it. See

const REGEX_LOCALHOST = '/^(127\.0\.0\.1|localhost)$/';

cc @MorrisJobke

Activity

  1. modified the milestone: on Jul 18, 2016
  2. coderkun commented on May 14, 2017

    @coderkun
    Contributor

    The regex with added IPv6 localhost would look like

    /^(127\.0\.0\.1|localhost|::1)$/

  3. MorrisJobke commented on May 14, 2017

    @MorrisJobke
    Member

    @coderkun Could I ask you to open a Pull Request with this change applied? That would be awesome :)

  4. added a commit that references this issue on May 15, 2017
  5. added this to the Nextcloud 12.0 milestone on May 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions