Skip to content

Improve compatibility for finding other name format python libraries. - #57

Closed
ar90n wants to merge 1 commit into
ndarray:masterfrom
ar90n:find_other_name_format_python_lib
Closed

ar90n wants to merge 1 commit into
ndarray:masterfrom
ar90n:find_other_name_format_python_lib

Conversation

@ar90n

@ar90n ar90n commented Mar 29, 2016

Copy link
Copy Markdown

When I build this project on Ubuntu machine, I went into some troubles.
These troubles were caused by the followings.

  • CMakeLists.txt finds only libboost_python.so or libboost_python3.so.
    So other name format library such as libboost_python-py35.so canot be found.
  • FindPythonLibsNew.cmake finds only libpython${MAJOR}.${MINOR}.so.
    So libpython${MAJOR}.${MINOR}m.so cannot be found.

I fixed above issues. Please review this pull request.

@ar90n ar90n closed this Mar 29, 2016
@ar90n ar90n reopened this Mar 29, 2016
@TallJimbo

Copy link
Copy Markdown
Member

@ar90n I'm sorry this has lingered for so long, but could you please try with the latest master to see if it also fixes your problem? I suspect #56 may have fixed it.

@ar90n ar90n closed this Jun 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants