Repository navigation
Use PythonLibs (cmake) - #56
Merged
Merged
Conversation
|
👍 I confirm that this PR fixes cmake build problems that I was having using Anaconda Python 3.5.1 on OS X. Thank you, @termoshtt ! This is the error I was getting before this PR after running |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This project cannot be compiled by cmake in Python3 environment since cmake cannot find the shared library such as
libpython3.5m.so.It is caused by libs/numpy/cmake/FindPythonLibsNew.cmake, which was copied from numexpr project:
https://github.com/pydata/numexpr/blob/master/FindPythonLibsNew.cmake
As argued on the issue pydata/numexpr#102 ,
this is because the shared library has additional suffix "m".
This bug has been fixed in the numexpr project, but it has not been copied yet.
Indeed, when I copy it, I can build in Python3 env.
And I also confirm that I can build with FindPythonLibs.cmake, which is supplied by the official cmake package.
So I propose to use FindPythonLIbs.cmake instead.
I apologize that this PR should be included in the previous one #39 .