Repository navigation
feat(flows): a step fetches the runner's own secret when it starts - #450
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
The rest of the design for a runner's own secrets for flow pieces.
- A piece declares the secrets it needs (runtime_json.secrets) and what it
sends outside DYNAMO (sends_data_to). Approval covers both.
- A task input a secret fills cannot also be a run argument, a flow setting, a
link or a managed input, compared without regard to case.
- A flow plan lists the secrets it needs and whether each is stored
(secrets_ready), and what it sends outside DYNAMO. Submit refuses a missing
or changed secret, a piece kind that cannot fetch one, and a run that binds a
secret but holds a piece that is not built in, approved or the runner's own.
- Submit binds each step's secrets to the run by id and version. Each such
step gets a one-time credential made by the adapter for that run and step.
- GET /runs/{id}/steps/{step}/secrets needs the runner's token and that
credential, and answers once. The wrapper adds the values to the piece's
inputs, prints nothing secret, and masks a value echoed in the result.
- The Ensemble Manager passes required_secrets, secrets_ready and
sends_data_to through. No value passes through it.
- A plan records who made it; a run binding a secret is refused when its submitter is someone else, and when a bound secret has no record of the version the plan saw. - The fetch rate limit counts per caller and run, after the ownership check, in a bounded table. - A run binding a secret is refused while the same user has another active run holding a piece that is not built in, approved or their own, and the other way round; the fetch checks again. The race this narrows is documented. - A Tapis app step, which holds the runner's token, is held to the same trust rule as stored code. - The issued event is written before the one-time claim; submitting again is the recovery for a lost answer. - The fixed inputs cannot be bound in any letter case, and the signing key must be at least 32 bytes.
wmobley
force-pushed
the
feat/flow-step-secrets
branch
from
November 20, 2026 03:45
48effc2 to
e6a781a
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rest of the design in #440 (a runner's own secrets for flow pieces); step 1, the routes where a user stores their own secrets, is #449.
runtime_json.secrets) and what it sends outside DYNAMO (sends_data_to). Approval covers both. The catalog sync keeps them; a piece whose registry copy has lost a declaration is refused at plan.secrets_ready), and what it sends outside DYNAMO. The Ensemble Manager passes these through asrequired_secrets,secrets_readyandsends_data_to; no value passes through it.GET /runs/{id}/steps/{step}/secretsneeds the runner's token and that credential, answers once, and re-checks the piece's trust and the secret's owner, scope and version.From an independent security review, fixed here: cross-user submit; the fetch rate limit now counts per caller and run after the ownership check; a run binding a secret is refused while the same user has another active run holding an untrusted piece, and the other way round (this narrows, but does not close, a race through readable run arguments; documented); Tapis app steps are held to the same trust rule; the fixed inputs cannot be bound in any letter case; the signing key must be at least 32 bytes.
Needs a new setting on the adapter pod (
step_secret_key, at least 32 bytes) for secrets to bind; without it a secret-bearing run is refused with 503 and nothing else changes.Not yet run against a live service: the one-time claim on real Hasura, Tapis handing each step its own credential, a task reaching the adapter's public address.
Tests: adapter 1085 passing with the four failures that predate this work; Ensemble Manager 501, type check clean.