Skip to content

feat(svo-adapter): a user stores, lists and deletes their own secrets - #449

Merged
wmobley merged 1 commit into
developfrom
feat/user-secrets-store
Nov 20, 2026
Merged

wmobley merged 1 commit into
developfrom
feat/user-secrets-store

Conversation

@wmobley

@wmobley wmobley commented Nov 20, 2026

Copy link
Copy Markdown
Contributor

Step 1 of the design in #440. Nothing uses a stored secret yet.

  • PUT /secrets/{name}, GET /secrets, DELETE /secrets/{name}, with the caller's own Tapis token. No route returns a value; a refused body is not echoed.
  • A secret cannot be changed while its owner has a run in progress, because a step of that run holds the same token.
  • At most 20 changes per user in ten minutes. Every change is recorded with who made it.
  • A model owner's secret must name a configuration, so it can never read as a user's secret. Tests prove a ciphertext cannot be moved between the two kinds, and fail if any role is granted access to the secret tables or to a run's bound secrets.

No table change: adapter.secret already allowed the user scope.

Known limits: the lock and the rate limit are per process, and the lock check and the write are not one step.

Tests: adapter 830 passing with the four failures that predate this work.

@vercel

vercel Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
monorepo Canceled Canceled Nov 20, 2026 3:06am UTC

Step 1 of the design for a runner's own secrets. Nothing uses a stored secret
yet.

- PUT /secrets/{name}, GET /secrets, DELETE /secrets/{name}, with the caller's
  own Tapis token. No route returns a value.
- A secret cannot be changed while its owner has a run in progress, because a
  step of that run holds the same token.
- At most 20 changes per user in ten minutes. Every change is recorded with
  who made it.
- A model owner's secret must name a configuration, so it can never read as a
  user's secret. A test fails if any role is granted access to the secret
  tables or to a run's bound secrets.
@wmobley
wmobley force-pushed the feat/user-secrets-store branch from 48e667a to 41a61da Compare November 20, 2026 02:53
@wmobley
wmobley merged commit 647fc6c into develop Nov 20, 2026
39 of 40 checks passed

This branch was successfully deployed

1 active deployment
Preview — 41a61da8 Deployed Nov 20, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant