Repository navigation
Reload the executions after fetching results (#110) - #152
Merged
Merged
Conversation
added 2 commits
August 29, 2026 20:39
Picks up 1771200018000_response_variable_standard_variable_fk and the metadata move of the four array relationships onto modelcatalog_standard_variable, merged as mintproject/graphql_engine#15. Also picks up the cascade migration (#14), which the pointer had not yet caught up with.
Registration writes the execution_result rows server-side, but the results table renders the executions held in MintThread's state, and handlePublishResults only refetches GetThreadExecution -- the pipeline and its counters, not the execution rows that carry the results. So a successful fetch left the table reading "No results available" until the user pressed Reload. That is #110's own symptom, still present on the first click. MintResults now reloads the current page of executions after a successful publish, through the same onFetchRuns path the Reload button uses. A failed publish still reloads nothing. Verified live against TACC on thread jx8ibyilmsmg1pvt: the registered row was deleted to restore the "before" state, and one click on Fetch results rendered the output with no Reload.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the last piece of #110.
What was wrong
Registration writes the
execution_resultrows server-side. The results table rendersthe executions held in
MintThread's state, andhandlePublishResultsrefetched onlyGetThreadExecution— the pipeline and its counters, not theexecutionrows thatcarry
results.So a successful fetch left the table reading
— No results available —until the userpressed Reload. That is #110's own symptom, still present on the first click.
The fix
MintResultsreloads the current page of executions after a successful publish, throughthe same
onFetchRunspath the Reload button already uses. A failed publish reloadsnothing.
Verification
Live against TACC, thread
jx8ibyilmsmg1pvt, modelSUBSIDE Allocation Specification:POST /v1/problemStatements/.../subtasks/jx8ibyilmsmg1pvt/outputs→ 200Outputs registered successfully, oneexecution_resultrow written.Fetch results rendered the output with no Reload.
933 tests green. The new assertion was checked to fail against the old code.
🤖 Generated with Claude Code
https://claude.ai/code/session_014wrbumQztWyA6uKoKbHohc