Repository navigation
fix(ts): resolve all TypeScript build errors blocking Vercel deploy - #14
Merged
Merged
Conversation
- Remove unused imports (React in JSX transform components, unused vars) - Replace GraphQL string literals with Kind enum values in apollo-client.test.ts - Add non-null assertions for possibly-undefined array accesses in tests - Fix null vs undefined mismatch in mutation-builder.test.ts - Fix type cast for never-typed variable in AuthProvider.test.tsx
mosoriob
added a commit
that referenced
this pull request
Aug 10, 2026
…115) The three delete mutations removed the provenance and permission rows first, copied from the Lit app. Those rows are what authorise the delete: the user role may remove one of these only while the row still carries a CREATE provenance event from that user, and every child on the tree is gated through the thread's provenance or permission. So the whole cascade matched 0 rows, and Hasura reports a filtered-out row as `null` with no errors key, which the app read as success. Deleting the row first does not work either -- those FKs were ON DELETE RESTRICT. graphql_engine now cascades them, so this deletes bottom-up and never touches provenance or permission. Two more faults fixed with it: - The port dropped Lit's dataslice_resource, dataslice and thread_data deletes. Nothing noticed while the mutation was a no-op, but since #104 started writing those rows a fixed delete would have hit an FK error. Order is load-bearing: dataslice is filtered through thread_data, so it goes first, which the deferred FK allows. - assertDeleted raises when _by_pk comes back null, so a delete the server declines can no longer render as a success toast. Requires graphql_engine PR #14. Fixes #99
mosoriob
added a commit
that referenced
this pull request
Aug 30, 2026
Picks up 1771200018000_response_variable_standard_variable_fk and the metadata move of the four array relationships onto modelcatalog_standard_variable, merged as mintproject/graphql_engine#15. Also picks up the cascade migration (#14), which the pointer had not yet caught up with.
mosoriob
added a commit
that referenced
this pull request
Aug 30, 2026
* chore: bump graphql_engine to main for the indicator FK migration Picks up 1771200018000_response_variable_standard_variable_fk and the metadata move of the four array relationships onto modelcatalog_standard_variable, merged as mintproject/graphql_engine#15. Also picks up the cascade migration (#14), which the pointer had not yet caught up with. * fix(ui-react): reload the executions after fetching results (#110) Registration writes the execution_result rows server-side, but the results table renders the executions held in MintThread's state, and handlePublishResults only refetches GetThreadExecution -- the pipeline and its counters, not the execution rows that carry the results. So a successful fetch left the table reading "No results available" until the user pressed Reload. That is #110's own symptom, still present on the first click. MintResults now reloads the current page of executions after a successful publish, through the same onFetchRuns path the Reload button uses. A failed publish still reloads nothing. Verified live against TACC on thread jx8ibyilmsmg1pvt: the registered row was deleted to restore the "before" state, and one click on Fetch results rendered the output with no Reload.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix all TypeScript build errors on the
developbranch that were failing the Vercel deployment.Changes (11 files)
Unused imports/variables (TS6133/TS6192)
Reactimports from JSX-runtime components (ModelTree.tsx,ModelsPage.tsx, test files)loginvariable inProtectedRoute.tsxOAuth2CallbackPageandProtectedRouteimports inApp.tsxviimport intest/setup.tsGraphQL Kind enum usage (TS2322)
"Document","Field", etc.) withKind.DOCUMENT,Kind.FIELD, etc. from thegraphqlpackage inapollo-client.test.tsOperationTypeNode.QUERYfor operation typePossibly undefined access (TS2532/TS18048)
nevertype cast inAuthProvider.test.tsxnulltoundefinedforhasFixedValueinmutation-builder.test.tsVerification
tsc --noEmit: exit 0 (zero errors)npm run build: exit 0 (tsc -b + vite build both pass)Kanban: t_0cf5ef4b