Skip to content

Raise event when status of a test manager changes - #4319

Merged
Don Jayamanne (DonJayamanne) merged 2 commits into
microsoft:masterfrom
DonJayamanne:results
Feb 7, 2019
Merged

Don Jayamanne (DonJayamanne) merged 2 commits into
microsoft:masterfrom
DonJayamanne:results

Conversation

@DonJayamanne

Copy link
Copy Markdown

For #4276

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • [n/a] Has a news entry file (remember to thank yourself!)
  • [n/a] Has sufficient logging.
  • [n/a] Has telemetry for enhancements.
  • [n/a] Unit tests & system/integration tests are added/updated
  • [n/a] Test plan is updated as appropriate
  • [n/a] package-lock.json has been regenerated by running npm install (if dependencies have changed)

@d3r3kk Derek Keeler (d3r3kk) left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please have a look at my comments, I think they make sense but if you have some reason to push ahead I'm ok with it.

@DonJayamanne Don Jayamanne (DonJayamanne) added the no-changelog No news entry required label Feb 7, 2019
@codecov

codecov Bot commented Feb 7, 2019 •

Copy link
Copy Markdown

Codecov Report

Merging #4319 into master will increase coverage by 22%.
The diff coverage is 72%.

@@           Coverage Diff            @@
##           master   #4319     +/-   ##
========================================
+ Coverage      57%     79%    +22%     
========================================
  Files         348     422     +74     
  Lines       14566   19402   +4836     
  Branches     2252    3122    +870     
========================================
+ Hits         8263   15252   +6989     
+ Misses       5774    4147   -1627     
+ Partials      529       3    -526
Flag Coverage Δ
#Linux 68% <72%> (?)
#Windows 54% <70%> (?)
#macOS 53% <70%> (?)

@codecov

codecov Bot commented Feb 7, 2019 •

Copy link
Copy Markdown

Codecov Report

Merging #4319 into master will increase coverage by 23%.
The diff coverage is 72%.

@@           Coverage Diff            @@
##           master   #4319     +/-   ##
========================================
+ Coverage      57%     79%    +23%     
========================================
  Files         348     422     +74     
  Lines       14566   19402   +4836     
  Branches     2252    3122    +870     
========================================
+ Hits         8263   15280   +7017     
+ Misses       5774    4119   -1655     
+ Partials      529       3    -526
Flag Coverage Δ
#Linux 68% <72%> (?)
#Windows 69% <72%> (?)
#macOS 68% <72%> (?)

@DonJayamanne
Don Jayamanne (DonJayamanne) merged commit a650612 into microsoft:master Feb 7, 2019
@lock lock Bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog No news entry required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants