Repository navigation
Fix test in CI - #13368
Merged
Mikhail Arkhipov (MikhailArkhipov) merged 20 commits intoAug 10, 2020
Merged
Fix test in CI#13368
Conversation
added 20 commits
May 5, 2020 21:15
Mikhail Arkhipov (MikhailArkhipov)
added
no-changelog
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #13368 +/- ##
==========================================
- Coverage 59.71% 59.69% -0.03%
==========================================
Files 670 670
Lines 37338 37338
Branches 5307 5307
==========================================
- Hits 22298 22289 -9
- Misses 13905 13911 +6
- Partials 1135 1138 +3
Continue to review full report at Codecov.
|
Kartik Raj (karrtikr)
approved these changes
Aug 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #13345
Fix test in CI. Change configuration target of
languageServerto workspace.- [ ] Has a news entry file (remember to thank yourself!).- [ ] Appropriate comments and documentation strings in the code.- [ ] Has sufficient logging.- [ ] Has telemetry for enhancements.- [ ] Unit tests & system/integration tests are added/updated.- [ ] Test plan is updated as appropriate.- [ ]package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed).- [ ] The wiki is updated with any design decisions/details.