Repository navigation
CI is failing on Multi-workspace tests - Multiple linters enabled #13345
Description
See failure here:
https://dev.azure.com/ms/vscode-python/_build/results?buildId=99934&view=ms.vss-test-web.build-test-results-tab
I'm going to disable this test so we can get an insiders build.
Activity
karrtikr commentedon Aug 7, 2020
Mikhail Arkhipov (@MikhailArkhipov) This failure has started after the merge of #13246. Can you please look into it?
IanMatthewHuff commentedon Aug 7, 2020
Note: I ported the disabling of this test into release for September since it was blocking getting a clean CI. So if there is an important fix needed make sure that we get it ported to release as well.
karrtikr commentedon Aug 7, 2020
I think the test caught a bug in this case, so we should try to fix it.
MikhailArkhipov commentedon Aug 8, 2020
I will look into it. Most probably test needs to be updated (or removed?) since LS can no longer be set per folder.
MikhailArkhipov commentedon Aug 10, 2020
#13368. There is no bug, just missed test update.
karrtikr commentedon Aug 10, 2020
Mikhail Arkhipov (@MikhailArkhipov) Great, just approved.
Unrelated doubt: What about the users who had
python.languageServerin their workspace folder settings? Should we do anything to migrate those?MikhailArkhipov commentedon Aug 10, 2020
It is generally unlikely since per-folder setting never really worked reliably. Pylance does not work per folder anyway, so there is nothing to migrate. With change in scope settings per folder (if any) become invalid and user should get vs code warning.
karrtikr commentedon Aug 11, 2020
I get this message when I open
settings.jsonand hover over the setting key. I was expecting to see some indication in the file explorer on the left or the problems window, without needing to open and hover, otherwise the language server will change silently for the users.Anyways, the original issue is solved so closing this.