Repository navigation
Revert "Logging cleanup." - #11732
Merged
Merged
Conversation
This reverts commit 5aaca27.
|
Kudos, SonarCloud Quality Gate passed!
|
Kartik Raj (karrtikr)
marked this pull request as ready for review
May 11, 2020 14:12
Kartik Raj (karrtikr)
requested review from
Eric Snow (ericsnowcurrently) and
Karthik Nadig (karthiknadig)
May 11, 2020 14:13
|
FYI, we'll are removing the old debugger this week, so we'll re-apply this change once that lands. We'll do it in the following branch: https://github.com/microsoft/vscode-python/tree/logging-changes-and-drop-old-debugger. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blocked on the discussion in the standup
Reverts #11606
Active GHA run: https://github.com/karrtikr/vscode-python/actions/runs/101515923
Looks like the logging change broke the TS debugger: