Skip to content

Revert "Logging cleanup." - #11732

Merged
Kartik Raj (karrtikr) merged 1 commit into
masterfrom
revert-11606-logging-cleanup
May 11, 2020
Merged

Kartik Raj (karrtikr) merged 1 commit into
masterfrom
revert-11606-logging-cleanup

Conversation

@karrtikr

@karrtikr Kartik Raj (karrtikr) commented May 11, 2020 •

Copy link
Copy Markdown

Blocked on the discussion in the standup

Reverts #11606

Active GHA run: https://github.com/karrtikr/vscode-python/actions/runs/101515923

Looks like the logging change broke the TS debugger:

C:\GIT\issues\s p\vscode-python>git bisect good 458f5456a8306c39126328edb786d6300fd79909
Bisecting: 8 revisions left to test after this (roughly 3 steps)
[bd22b95dd12c1d41f322f14932349c9946092ba3] Fix storage not being used (#11649)

C:\GIT\issues\s p\vscode-python>git bisect good
Bisecting: 4 revisions left to test after this (roughly 2 steps)
[226b8f8a64be919a6661c014a484b271bbc222fe] Fix scrolling (#11681)

C:\GIT\issues\s p\vscode-python>git bisect good
Bisecting: 2 revisions left to test after this (roughly 1 step)
[79840763ea52dcff4b5cd6f6b1926b10b93f22d1] Leave pipenv in a corner until the user decides to select an interpreter (#11654)

C:\GIT\issues\s p\vscode-python>git bisect bad
Bisecting: 0 revisions left to test after this (roughly 0 steps)
[5aaca27b5f5e058334963f8b4716e1be287a68f9] Logging cleanup. (#11606)

C:\GIT\issues\s p\vscode-python>git bisect bad
5aaca27b5f5e058334963f8b4716e1be287a68f9 is the first bad commit
commit 5aaca27b5f5e058334963f8b4716e1be287a68f9

    Logging cleanup. (#11606)

    For #9837

:040000 040000 6269403b6d01ae8ffbfa66a684852ff06e50c620 46e809c6add0f4723c35eb7e4ff31c2c1d1d6f9e M      src

@karrtikr Kartik Raj (karrtikr) added the no-changelog No news entry required label May 11, 2020
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ericsnowcurrently

Copy link
Copy Markdown

FYI, we'll are removing the old debugger this week, so we'll re-apply this change once that lands. We'll do it in the following branch: https://github.com/microsoft/vscode-python/tree/logging-changes-and-drop-old-debugger.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karrtikr
Kartik Raj (karrtikr) merged commit 66600e3 into master May 11, 2020
@karrtikr
Kartik Raj (karrtikr) deleted the revert-11606-logging-cleanup branch May 11, 2020 18:02
@lock lock Bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog No news entry required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants