Repository navigation
Logging cleanup. - #11606
Merged
Eric Snow (ericsnowcurrently) merged 30 commits intoMay 8, 2020
Merged
Logging cleanup.#11606Eric Snow (ericsnowcurrently) merged 30 commits into
Eric Snow (ericsnowcurrently) merged 30 commits into
Conversation
Eric Snow (ericsnowcurrently)
requested a review
from Karthik Nadig (karthiknadig)
May 5, 2020 22:48
Karthik Nadig (karthiknadig)
approved these changes
May 6, 2020
Eric Snow (ericsnowcurrently)
force-pushed
the
logging-cleanup
branch
from
May 6, 2020 19:02
e0d4951 to
0cd4d61
Compare
Eric Snow (ericsnowcurrently)
force-pushed
the
logging-cleanup
branch
from
May 8, 2020 01:54
0cd4d61 to
875235f
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
| [LogLevel.Error]: 'ERROR', | ||
| [LogLevel.Warn]: 'WARNING', | ||
| [LogLevel.Info]: 'INFORMATION', | ||
| [LogLevel.Debug]: 'DEBUG', |
There was a problem hiding this comment.
Wait we don't even support DEBUG or DEBUG-TRACE, why are we adding their log levels? Karthik Nadig (@karthiknadig) Eric Snow (@ericsnowcurrently)
IMO we should just've verbose instead.
There was a problem hiding this comment.
I added these so there would be no confusion later when we wanted them, which I expect we will.
Kartik Raj (karrtikr)
pushed a commit
that referenced
this pull request
May 11, 2020
This reverts commit 5aaca27.
Kartik Raj (karrtikr)
pushed a commit
that referenced
this pull request
May 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #9837.
[ ] Has a news entry file (remember to thank yourself!).[ ] Has sufficient logging.[ ] Has telemetry for enhancements.[ ] Unit tests & system/integration tests are added/updated.[ ] Test plan is updated as appropriate.[ ]package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed).[ ] The wiki is updated with any design decisions/details.