Skip to content

CI: Keep NuGet vulnerability findings non-blocking #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Charles Gagnon (Charles-Gagnon) merged 1 commit into from
Oct 16, 2026
+2 −0
Merged

CI: Keep NuGet vulnerability findings non-blocking #241

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/pr-validation.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ jobs:
dotnet build dirs.proj
env:
DOTNET_ROLL_FORWARD: LatestMajor
# NuGet package vulnerability errors should not block PR validation.
WarningsNotAsErrors: NU1901;NU1902;NU1903;NU1904

@ch0707 Chetana Kethinedi (ch0707) Oct 16, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we limit this to low and moderate findings?

@Charles-Gagnon Charles Gagnon (Charles-Gagnon) Oct 16, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather not - since any of those will currently block the PR build from completing due to us surfacing all warnings as errors.

As mentioned in the description - we track these vulnerabilities in other ways so having this PR pipeline fail for any of them is just noise and very unlikely to catch "real" issues.

- uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2
with:
name: tests
Expand Down
Loading