Repository navigation
CI: Keep NuGet vulnerability findings non-blocking - #241
Open
Charles Gagnon (Charles-Gagnon) wants to merge 1 commit into
Open
Charles Gagnon (Charles-Gagnon) wants to merge 1 commit into
Charles Gagnon (Charles-Gagnon) wants to merge 1 commit into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Charles Gagnon (Charles-Gagnon)
marked this pull request as ready for review
October 15, 2026 23:36
Charles Gagnon (Charles-Gagnon)
requested review from
Matteo Taveggia (Matteo-T) and
Chetana Kethinedi (ch0707)
as code owners
October 15, 2026 23:36
Contributor
|
this PR summary has internal ado stuff that needs to be cleaned up and not relevant |
| env: | ||
| DOTNET_ROLL_FORWARD: LatestMajor | ||
| # NuGet package vulnerability errors should not block PR validation. | ||
| WarningsNotAsErrors: NU1901;NU1902;NU1903;NU1904 |
Contributor
There was a problem hiding this comment.
can we limit this to low and moderate findings?
Collaborator
Author
There was a problem hiding this comment.
I would rather not - since any of those will currently block the PR build from completing due to us surfacing all warnings as errors.
As mentioned in the description - we track these vulnerabilities in other ways so having this PR pipeline fail for any of them is just noise and very unlikely to catch "real" issues.
Chetana Kethinedi (ch0707)
requested changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep NuGet package vulnerability findings (NU1901-NU1904) visible as warnings without blocking GitHub PR validation. This prevents vulnerabilities from blocking PRs that are unrelated to the packages themselves - we track these vulnerabilities through other means.