This repository was archived by the owner on Apr 14, 2022. It is now read-only.
Repository navigation
Handle named tuples - #339
Merged
Mikhail Arkhipov (MikhailArkhipov) merged 22 commits intoNov 5, 2018
Merged
Conversation
added 14 commits
October 23, 2018 19:40
| } | ||
|
|
||
| [TestMethod, Priority(0)] | ||
| public async Task AstForwardRefFunction2() { |
Contributor
There was a problem hiding this comment.
Can be a parameterized test.
| => klass.Contains(ProjectState.ClassInfos[BuiltinTypeId.Function]) || klass.Contains(ProjectState.ClassInfos[BuiltinTypeId.BuiltinFunction]); | ||
|
|
||
| public override IAnalysisSet Call(Node node, AnalysisUnit unit, IAnalysisSet[] args, NameExpression[] keywordArgNames) { | ||
| var returnTypes = GetFunctionOverloads().Where(o => o.ReturnType != null).SelectMany(o => o.ReturnType); |
Contributor
There was a problem hiding this comment.
Do we need .Distinct() here?
Use builtin types from interpreter
| /// </summary> | ||
| public static void DeleteIndex(this IAnalysisSet self, Node node, AnalysisUnit unit, IAnalysisSet index) { | ||
| } | ||
| public static void DeleteIndex(this IAnalysisSet self, Node node, AnalysisUnit unit, IAnalysisSet index) { } |
Contributor
There was a problem hiding this comment.
Empty static method?
There was a problem hiding this comment.
Apparently it is called from DDG... Let's leave this alone until we decide fate of the DDG.
Alexander Sher (AlexanderSher)
approved these changes
Nov 5, 2018
Jake Bailey (jakebailey)
pushed a commit
to jakebailey/python-language-server
that referenced
this pull request
Nov 1, 2019
Handle named tuples
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15
Type[T]fromtypingtotypeinfoand the AST analysisnamedtuplefromcollectionsvia typeshed annotationsImplement wrapper over tuple so we can expose declared members in completion - separate item in #343